Not returning correct information

[abernut]

Hello, I am very new to the C++ world (2 months)

I have an assignment where we need to write a program that asks the user for his first name in lowercase, validate it, and return it. Then ask for their last name in lowercase, validate it, and return it. Then return the full name and show how many characters it consist of.

My validation works fine but it's not returning the name.

ie...Please enter your first name in lowercase: mike
Your first name in lowercase is

Here is what I have thus far:
(Also the input of each string must be done through a function and the function must return a Boolean parameter indicating the validity of the input)


//Assignment07, Pointers, Functions, and Input Validation
//Michael
//November, 12, 2008

#include <iostream>
#include <cstdlib>

using namespace std;

bool lowerCase(char *);

void main()
{
char first, last;
bool validLetters;

do
{
cout << "Enter your first name in lower case letters: ";
validLetters = lowerCase(&firs t);
if (!validLetters) cout << "Invalid entry. Try again...\n";
} while (!validLetters) ;

cout << "\n\nYour first name in lower case is: " << first << endl;

do
{
cout << "Enter your last name in lower case letters: ";
validLetters = lowerCase(&last );
if (!validLetters) cout << "Invalid entry. Try again...\n";
} while (!validLetters) ;
cout << "\n\nYour last name in lower case is: " << last << endl;

}

bool lowerCase(char *chars)
{
int i,len;
char buf[100];
bool validLetters = true;

cin.getline(buf ,100);
len = strlen(buf);
i = 0;
while (validLetters && i < len)
{
if ((buf[i] < 'a') || (buf[i] > 'z'))
validLetters = false;
i++;
}

if (validLetters)
{
(*chars) = atoi(buf);
if (((*chars) < 0) || ((*chars) > 100))
validLetters = false;
}

return validLetters;
}


Thank you for your help. And I thought Spanish was rough..lol

[JosAH]

A single char can never store an entire name; use a char[] (an array of chars)
or a C++ string instead.

kind regards,

Jos

[boxfish]

Your function is not using the argument you pass to it. Seeing as that argument consists of a pointer to only one letter, it's not very useful anyway. Maybe what you meant to do was create an array of chars like buf in main, and then pass it to the function and have the function read into it, so that what the user entered can be accessed from main after the function is done.
Hope this makes sense. Good luck.

[Ganon11]

It might be a good idea to separate your input function from your validation function. That is, instead of one function that gets the input and validates it, try two functions: one to get the string. It doesn't care what gets put into the string, it just gets the string. Your second function takes a string and returns true if it meets your criteria (in this case, all lowercase 'letter' characters), false otherwise. Then your while loop will look something like:

do {
   cout << "Prompt for string" << endl;
   getInput(firstName);
} while (!valid(firstName));

Or don't even use a separate function for getting the input. If you use an std::string instead of messy char*s, it's as easy as using cin >> firstName.

My overwhelming suggestion would be to use std::strings instead of char[]s and char*s - it will save you a LOT of trouble down the line.

[abernut]

I understand why I have to use an array. I tried changing my char variable to arrays and now I get two errors:
Error 1 error C2664: 'lowerCase' : cannot convert parameter 1 from 'char (*)[100]' to 'char *'

here is what I have:

#include <iostream>
#include <cstdlib>

using namespace std;

bool lowerCase(char *);

void main()
{
char first[100];
char last[100];
bool validLetters;

do
{
cout << "Enter your first name in lower case letters: ";
validLetters = lowerCase(&firs t);
if (!validLetters) cout << "Invalid entry. Try again...\n";
} while (!validLetters) ;

cout << "\n\nYour first name in lower case is: " << first << endl;

do
{
cout << "Enter your last name in lower case letters: ";
validLetters = lowerCase(&last );
if (!validLetters) cout << "Invalid entry. Try again...\n";
} while (!validLetters) ;
cout << "\n\nYour last name in lower case is: " << last << endl;

}

bool lowerCase(char *chars)
{
int i,len;
char buf[100];
bool validLetters = true;

cin.getline(buf ,100);
len = strlen(buf);
i = 0;
while (validLetters && i < len)
{
if ((buf[i] < 'a') || (buf[i] > 'z'))
validLetters = false;
i++;
}

if (validLetters)
{
(*chars) = atoi(buf);
if (((*chars) < 0) || ((*chars) > 100))
validLetters = false;
}

return validLetters;
}

[abernut]

Is it because my Function is only set for a single variable char?

[boxfish]

first and last are already char*s. You don't have to take their addresses with &, just pass them to the function. That should clear up your errors. Your function is still not reading into the char array that you pass to it. Get rid of buf and read into chars.
Hope this helps.
Edit:
By the way, it would be helpful if you used code tags around your code. Put [CODE] before the code and [/CODE] after it, so it shows up in a code box and the indentation isn't wrecked. Thanks.

[abernut]

Thank you boxfish....Can I borrow your brain for the rest of the semester. I really would like to learn this. I have bought two additional books, besides what the class requires....som ething just isn't clicking.

But I did what you said and indeed, it cleared up those two errors, but something still isn't right...

#include <iostream>
#include <cstdlib>

using namespace std;

bool lowerCase(char *);

void main()
{
char first[100];
char last[100];
bool validLetters;

do
{
cout << "Enter your first name in lower case letters: ";
validLetters = lowerCase(first);
if (!validLetters) cout << "Invalid entry. Try again...\n";
} while (!validLetters);

cout << "\n\nYour first name in lower case is: " << first << endl;

do
{
cout << "Enter your last name in lower case letters: ";
validLetters = lowerCase(last);
if (!validLetters) cout << "Invalid entry. Try again...\n";
} while (!validLetters);
cout << "\n\nYour last name in lower case is: " << last << endl;

}

bool lowerCase(char *chars)
{
int i,len;
char chars[100];
bool validLetters = true;

cin.getline(chars,100);
len = strlen(chars);
i = 0;
while (validLetters && i < len)
{
if ((chars[i] < 'a') || (chars[i] > 'z'))
validLetters = false;
i++;
}

if (validLetters)
{
(*chars) = atoi(chars);
if (((*chars) < 0) || ((*chars) > 100))
validLetters = false;
}

return validLetters;
}

I am now getting a Error 1 error C2082: redefinition of formal parameter 'chars' On line 36

Thanks for all of your help.

[boxfish]

I am now getting a Error 1 error C2082: redefinition of formal parameter 'chars' On line 36

It says what it means and it means what it says; chars is already declared as the parameter to the function and there's no need to declare it again.

Can I borrow your brain for the rest of the semester.

Sorry, I need it for Calc 1. :-)

[abernut]

I deleted that line of code and now I get now errors but......it still returns nothing.

ie...Please enter your first name in lower case: mike
Your first name in lower case is


Ahhhh Calc1. I had to take a trig/calc class that was combined together. Made for many a fun night.

Luckily I am finished with Math for the remainder of my degree.

I really do appreciate all the help.

[Banfa]

On line 51, I do not know what you think the function atoi does (OK I could guess) I seriously suggest that you look it up in your text book or on the internet.

You can not use chars to return both the string and the length of the string.

[abernut]

Thanks Banfa....

One last question and I will leave you alone, I hope.

How would you return the total number of characters in the first and last name entered.

I have played around with it, but it keeps returning the number of the entire array, not sure how to tell it to stop at the null terminator.

Thanks

[Ganon11]

If you're using char*s or char[]s, check the strlen function.