Checking Empty textbox

[IraqiAli]

Ok i have 6 textboxes, and the user is required to fill in each of them. so i want to do a check to make sure none are left blank, but im having a little trouble.

i tried doing

If txtChoice1.text =  "" Then
MsgBox ("You have missed out a preference.")
Else
If txtChoice2.text = ""  Then

but that never seemed to work.

please help.

[scripto]

quick and dirty:

If txtChoice1.text = "" Then
     MsgBox ("You have missed out a preference.")
elseIf txtChoice2.text = "" Then
     MsgBox ("You have missed out a preference.")
elseIf txtChoice3.text = "" Then
     MsgBox ("You have missed out a preference.")
end if

make elseif one word.

if you're using VB6, look into using arrays of textboxes to make this easier.

[IraqiAli]

quick and dirty:

If txtChoice1.text = "" Then
MsgBox ("You have missed out a preference.")
elseIf txtChoice2.text = "" Then
MsgBox ("You have missed out a preference.")
elseIf txtChoice3.text = "" Then
MsgBox ("You have missed out a preference.")
end if

make elseif one word.

if you're using VB6, look into using arrays of textboxes to make this easier.

it still never worked. even though i fill in all the textboxes - i still get the message.

[willakawill]

it still never worked. even though i fill in all the textboxes - i still get the message.

Try this:

If Len(Trim(txtChoice1.Text)) = 0 Then

This is a more generic way to do this. It will check all of the textboxes on your form:

Dim tmp As Control
    
    For Each tmp In Me.Controls
        If TypeOf tmp Is TextBox Then
            If Len(Trim(tmp.Text)) = 0 Then
                'put your message here
            End If
        End If
    Next tmp

[TNT]

You could use:

If txtChoice1 <> "" Or txtChoice2 <> "" Or txtChoice3 <> "" Or txtChoice4 <> "" Or txtChoice5 <> "" Or txtChoice5 <> "" Then
'Code goes here
End If

[Killer42]

it still never worked. even though i fill in all the textboxes - i still get the message.

That's really odd. Could you copy and paste back here the code which didn't work? Because willakawill's code really should have worked. I'd have to guess that you might have made a mistake in something like a control or variable name.

[IraqiAli]

That's really odd. Could you copy and paste back here the code which didn't work? Because willakawill's code really should have worked. I'd have to guess that you might have made a mistake in something like a control or variable name.

well i couldnt use this code

Dim tmp As Control
    
    For Each tmp In Me.Controls
        If TypeOf tmp Is TextBox Then
            If Len(Trim(tmp.Text)) = 0 Then
                'put your message here
            End If
        End If
    Next tmp

because it checks all the textboxes on the form, but i have other texboxes than the 6 that need to be filled in. But thanks for the code anyway - i used it for something else i was doing.

i used Len(Trim(tmp.Te xt)) = 0 with If statements and it worked

thank you everyone for your help

[willakawill]

You can still use a loop like this just by testing for the common name of your control array:

Dim tmp As Control
    
    For Each tmp In Me.Controls
        If StrComp(Left(tmp.Name, 9), "txtChoice") = 0 Then
            If Len(Trim(tmp.Text)) = 0 Then
                'put your message here
            End If
        End If
    Next tmp

[IraqiAli]

You can still use a loop like this just by testing for the common name of your control array:

Dim tmp As Control
    
    For Each tmp In Me.Controls
        If StrComp(Left(tmp.Name, 9), "txtChoice") = 0 Then
            If Len(Trim(tmp.Text)) = 0 Then
                'put your message here
            End If
        End If
    Next tmp

that is really helpful. Thanks :)

[willakawill]

You are very welcome

[knychtell]

Ok , would you like to use an errorprovider, cause it is better rather than to show a pop-up message everytime a user writes wrong, info. and an errorprovider gives a lot of room for mistakes, wihtout giving off too many msgboxes.

add this on every txtbox

if txtbox1.text=nothing then
errorprovider1.seterror(txtbox1, "Txtbox must b\not be left blank!") 
e.cancel'

w/c tells a user that he must place a valid value in the 1st txtbox before he can leave and jump to another txtbox.


add this to the 2 lines above

elseif
 errorprovider.seterror(txtbox1,"")
'which lets the user jump to another txtbox if the user entere a right txt or number

end sub

add this code to every txtboxes you have for validation purposses.

actually you can still add validating and validated event handler to every txtbox.

hope this may help ya...

[willakawill]

errorprovider is a .net class. No mention of .net in the op's question but that does not mean the op is not using .net. A lot of new programmers who come here don't seem to know what .net is. Largely, I guess, because of the new microsoft naming policy vb 2005