Same Random result ?!

[mironline]

dear friends .


I want to create a instance of [R] class in [foreach] statement.
but all 10 responses are same same!



//

using System;

public partial class Class1: System.Web.UI.Page
{
protected void Page_Load(object sender, EventArgs e)
{
string[] k = new string[10];
R cl;
foreach(string kx in k)
{
cl = new R();
Response.Write(cl.Ra() + "<br>");
}
}
}

public class R
{
private Random r;
public R()
{
r = new Random();
}
public int Ra()
{
return r.Next(100);
}
}

[Plater]

Its because you do it so fast.
The random seed comes from the timer object, all of those calls happen before it changes.

foreach (string kx in k)
{
   cl = new R();
   Console.WriteLine(cl.Ra());//i was in a windows app so I changed it to this
   System.Threading.Thread.Sleep(100);
}

That gave me different numbers each time.

I would recomend you maybe re-think your class design since Thread.Sleep() is probably not good in a webpage context.

Perhaps like this:

public class R
{
   private static Random r=new Random();
   public R()
   {
      //r = new Random();
   }
   public int Ra()
   {
      return r.Next(100);
   }
}

[Curtis Rutland]

Unless there is more that you will be doing with this class, why do you need the class in the first place?

The same results can be achieved much simpler:

public partial class _Default : System.Web.UI.Page
{
    protected void Page_Load(object sender, EventArgs e)
    {
        string[] k = new string[10];
        Random cl = new Random();
        foreach (string kx in k)
            Response.Write(cl.Next(100) + "<br>");
    }
}

Its because you do it so fast.
The random seed comes from the timer object, all of those calls happen before it changes.

foreach (string kx in k)
{
   cl = new R();
   Console.WriteLine(cl.Ra());//i was in a windows app so I changed it to this
   System.Threading.Thread.Sleep(100);
}

That gave me different numbers each time.

I would recomend you maybe re-think your class design since Thread.Sleep() is probably not good in a webpage context.

Perhaps like this:

public class R
{
   private static Random r=new Random();
   public R()
   {
      //r = new Random();
   }
   public int Ra()
   {
      return r.Next(100);
   }
}

[mironline]

I would recomend you maybe re-think your class design since Thread.Sleep() is probably not good in a webpage context.

thank you very very much.