Form validation still allows submission of empty fields

**Akhilesh1505** · Mar 22 '07, 12:13 PM

Originally posted by elsheh

Hi.. guys
I’m trying to use JavaScript to validate my HTML for empty fields. My code is as below. The problem is that I can escape validation and submit empty fields.

Any clue?

<html>
<head>
<script language="JavaS cript">
function isEmpty(inputSt r,fieldname){
if (inputStr==null || inputStr==""){
alert("please fill in the box")
document.form1. fieldname.focus ();
document.form1. fieldname.selec t();
return false;
} else {
return true;
}

}
</script> </head>
<body>
<form name="form1" method="GET" action=”??????? ??”>
<p> User ID:
<input type="text" name="txt1" onBlur="isEmpty (txt1.value,txt 1.name)"/>
<br />
<p> User Name:
<input type="text" name="txt2" onBlur="isEmpty (txt2.value,txt 2.name)"/>
<br /> <br />
<input type="submit" VALUE="SUBMIT" />
</form> </body> </html>

You had given wrong
path in action=”??????? ??”
use like this action="".

Akhilesh

**elsheh** · Mar 22 '07, 01:51 PM

Thanx
The problem is not because of the action attribute, you may eliminate it. The issue is how to prevent of submission empty fields. (got it?)
Cheers

Originally posted by Akhilesh1505

You had given wrong
path in action=”??????? ??”
use like this action="".

Akhilesh

**acoder** · Mar 22 '07, 03:18 PM

Instead of passing the name, pass the object itself, e.g. txt1. Then in your function, in place of

Code:

document.form1.fieldname.focus()

you can have

Code:

fieldname.focus()

because fieldname is the text box object.

**elsheh** · Mar 22 '07, 05:00 PM

thanx acoder

but still doesn't work properly.I mean, i still able to submit empty fields.
plz help

Originally posted by acoder

Instead of passing the name, pass the object itself, e.g. txt1. Then in your function, in place of

Code:

document.form1.fieldname.focus()

you can have

Code:

fieldname.focus()

because fieldname is the text box object.

**iam_clint** · Mar 22 '07, 05:11 PM

[HTML]
<html>
<head>
<script language="JavaS cript">
function isEmpty(inputSt r,fieldname){
if (inputStr==null || inputStr==""){
alert("please fill in the box")
document.form1. fieldname.focus ();
document.form1. fieldname.selec t();
return false;
} else {
return true;
}
}
function validate() {
//check for blank input boxes here
//possibly alert("hey you didn't fill in everything"); and return false; if there is blank boxes (stops the submission);
//else return true
}
</script> </head>
<body>
<form name="form1" method="GET" onsubmit="valid ate();" action=”??????? ??”>
<p> User ID:
<input type="text" name="txt1" onBlur="isEmpty (txt1.value,txt 1.name)"/>
<br />
<p> User Name:
<input type="text" name="txt2" onBlur="isEmpty (txt2.value,txt 2.name)"/>
<br /> <br />
<input type="submit" VALUE="SUBMIT" />
</form> </body> </html>
[/HTML]

Changed title of thread to more suit the question being asked

**Akhilesh1505** · Mar 23 '07, 10:10 AM

Originally posted by elsheh

Hi.. guys
I’m trying to use JavaScript to validate my HTML for empty fields. My code is as below. The problem is that I can escape validation and submit empty fields.

Any clue?

<html>
<head>
<script language="JavaS cript">
function isEmpty(inputSt r,fieldname){
if (inputStr==null || inputStr==""){
alert("please fill in the box")
document.form1. fieldname.focus ();
document.form1. fieldname.selec t();
return false;
} else {
return true;
}

}
</script> </head>
<body>
<form name="form1" method="GET" action=”??????? ??”>
<p> User ID:
<input type="text" name="txt1" onBlur="isEmpty (txt1.value,txt 1.name)"/>
<br />
<p> User Name:
<input type="text" name="txt2" onBlur="isEmpty (txt2.value,txt 2.name)"/>
<br /> <br />
<input type="submit" VALUE="SUBMIT" />
</form> </body> </html>

you are doing validation on onBlur event of textbox,
If you want to validate on onSubmit event of form then
you need to do like this.
<form name="form1" method="GET" action=”??????? ??” onSubmit="valid ate()" >
and then make a validate() function in javascript.

**Logician** · Mar 23 '07, 11:35 AM

Originally posted by Akhilesh1505

you are doing validation on onBlur event of textbox,
If you want to validate on onSubmit event of form then
you need to do like this.
<form name="form1" method="GET" action=”??????? ??” onSubmit="valid ate()" >
and then make a validate() function in javascript.

Code:

<form name="form1" method="GET" action=”?????????” onSubmit="[B]return[/B]  validate()" >

**elsheh** · Mar 23 '07, 02:58 PM

how about parameters?
cheers

Originally posted by Logician

Code:

<form name="form1" method="GET" action=”?????????” onSubmit="[B]return[/B]  validate()" >

**acoder** · Mar 23 '07, 06:09 PM

See this link.

**elsheh** · Mar 24 '07, 02:58 PM

thanx acoder
i still unable to solve this problem. could you help plz.
cheers

Originally posted by acoder

See this link.

**ssh** · Mar 24 '07, 04:35 PM

Originally posted by elsheh

Hi.. guys
I’m trying to use JavaScript to validate my HTML for empty fields. My code is as below. The problem is that I can escape validation and submit empty fields.

Any clue?

Code:

 <html> 
<head>
<script language="JavaScript">
function isEmpty(inputStr,fieldname){
if (inputStr==null || inputStr==""){
alert("please fill in the box")
document.form1.fieldname.focus();
document.form1.fieldname.select();
return false;
} else {
return true;
}
 
}
</script> </head>
<body>
<form name="form1" method="GET" action=”?????????”>
<p> User ID:
<input type="text" name="txt1" onBlur="isEmpty(txt1.value,txt1.name)"/> 
<br />
<p> User Name:
<input type="text" name="txt2" onBlur="isEmpty(txt2.value,txt2.name)"/>
<br /> <br />
<input type="submit" VALUE="SUBMIT" />
</form> </body> </html>

hi!
just try this one!!!!
nBlur="isEmpty( this,txt1.name) ";

function isEmpty(inputSt r,fieldname){
if (inputStr.value .length==0 || inputStr==""){
alert("please fill in the box")
}

Regards,
ssh

**acoder** · Mar 26 '07, 07:55 AM

Originally posted by ssh

hi!
just try this one!!!!
nBlur="isEmpty( this,txt1.name) ";

function isEmpty(inputSt r,fieldname){
if (inputStr.value .length==0 || inputStr==""){
alert("please fill in the box")
}

Regards,
ssh

Whilst in principle this may work (though in this case it won't), it can be extremely annoying to have an alert onblur. Blurring can occur without user intervention, e.g. another program gains focus. An error message next to the field is much better. On the other hand, if it's an onsubmit or even onchange error check, then an alert should be fine.

**acoder** · Mar 26 '07, 08:04 AM

Originally posted by elsheh

how about parameters?
cheers

In your validate() function, you don't need parameters. Just reference the text fields using their names. If you want to, you can pass the form reference as "this":

Code:

return validate(this);

Then in your validate function:

Code:

function validate(form) {
 var txt1 = form.txt1;
 if (txt1.value=="") {
   alert ("Please fill in the box");
   txt1.focus();
   return false;
 }
 .... // txt2 and any other text boxes
 return true;
}

Form validation still allows submission of empty fields

Form validation still allows submission of empty fields

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment