Multiselect Form Filter Syntax Error

[JpjVB]

I'm having difficulty filtering a form using a multiselect list box when using some Allen Browne code. I get the error "Syntax Error (missing operator)in query expression '([City] IN (""Sydney"Londo n)'. - when I filter the cities Sydney and London from the multiselect list box in the form. The list box multiselect is set to Simple. The code breaks at Me.Filter = strWhere four lines from the end. Thanks for looking!

_______________ _______________ _______________ ____________
Private Sub cmdFilter_Click ()
'Purpose: Build up the criteria string form the non-blank search boxes, and apply to the form's Filter.
'Notes: 1. We tack " AND " on the end of each condition so you can easily add more search boxes; _
we remove the trailing " AND " at the end.
' 2. The date range works like this: _
Both dates = only dates between (both inclusive. _
Start date only = all dates from this one onwards; _
End date only = all dates up to (and including this one).
Dim strWhere As String
Dim strCity As String
Dim varSelected As Variant
Dim lngLen As Long 'Length of the criteria string to append to.
Const conJetDate = "\#mm\/dd\/yyyy\#" 'The format expected for dates in a JET query string.

'************** *************** *************** *************** ************
'Look at each search box, and build up the criteria string from the non-blank ones.
'************** *************** *************** *************** ************
'Text field example. Use quotes around the value in the string.
If Me.txtFilterCit y.ItemsSelected .Count > 0 Then
For Each varSelected In Me.txtFilterCit y.ItemsSelected
strCity = strCity & """" & Me.txtFilterCit y.ItemData(varS elected)
Next varSelected
strWhere = strWhere & "([City] IN (" & strCity & ") AND "
End If

If Not IsNull(Me.txtFi lterCity) Then
strWhere = strWhere & "([City] = """ & Me.txtFilterCit y & """) AND "
End If

'Another text field example. Use Like to find anywhere in the field.
If Not IsNull(Me.txtFi lterMainName) Then
strWhere = strWhere & "([MainName] Like ""*" & Me.txtFilterMai nName & "*"") AND "
End If

'Number field example. Do not add the extra quotes.
If Not IsNull(Me.cboFi lterLevel) Then
strWhere = strWhere & "([LevelID] = " & Me.cboFilterLev el & ") AND "
End If

'Yes/No field and combo example. If combo is blank or contains "ALL", we do nothing.
If Me.cboFilterIsC orporate = -1 Then
strWhere = strWhere & "([IsCorporate] = True) AND "
ElseIf Me.cboFilterIsC orporate = 0 Then
strWhere = strWhere & "([IsCorporate] = False) AND "
End If

'Date field example. Use the format string to add the # delimiters and get the right international format.
If Not IsNull(Me.txtSt artDate) Then
strWhere = strWhere & "([EnteredOn] >= " & Format(Me.txtSt artDate, conJetDate) & ") AND "
End If

'Another date field example. Use "less than the next day" since this field has times as well as dates.
If Not IsNull(Me.txtEn dDate) Then 'Less than the next day.
strWhere = strWhere & "([EnteredOn] < " & Format(Me.txtEn dDate + 1, conJetDate) & ") AND "
End If

'************** *************** *************** *************** ************
'Chop off the trailing " AND ", and use the string as the form's Filter.
'************** *************** *************** *************** ************
'See if the string has more than 5 characters (a trailng " AND ") to remove.
lngLen = Len(strWhere) - 5
If lngLen <= 0 Then 'Nah: there was nothing in the string.
MsgBox "No criteria", vbInformation, "Nothing to do."
Else 'Yep: there is something there, so remove the " AND " at the end.
strWhere = Left$(strWhere, lngLen)
'For debugging, remove the leading quote on the next line. Prints to Immediate Window (Ctrl+G).
'Debug.Print strWhere

'Finally, apply the string as the form's Filter.
Me.Filter = strWhere
Me.FilterOn = True
End If
End Sub

[MikeTheBike]

Hi

Perhaps you could modify you loop like this

    For Each varSelected In Me.txtFilterCity.ItemsSelected
        strCity = strCity & ",""" & Me.txtFilterCity.ItemData(varSelected) & i & """"
    Next varSelected
    
    strCity = Mid(strCity, 2)  'REMOVES LEADING COMMA
    
    strWhere = strWhere & "([City] IN (" & strCity & ") AND "

I think that may get rid of the that particulare error (but there may be more!).


MTB