Blackjack Code Help!!

**bvdet** · Jan 8 '09, 08:09 PM

We have a recent blackjack thread that addresses some of your concerns.

blackjack game

Three classes are defined: Card (defines suits and rank, including the Ace), Deck (creates a deck of cards, self.cards contains the Card objects), and BJ. BJ() is the game itself and has methods deal_hand(), hit_hand(), score_hand_BJ() (this is where the Ace is counted as 1 or 11 automatically), play() (the game loop), and play_over() (the game loop is summarized and results are displayed).

Your code has other problems. For example, selecting "H" for hit does not actually give the player a hit because you are using "H" instead of "h" in the if statement. The computer's hand should be automatically hit if below the threshold, but is only hit if the user elects to receive one. There is no check to see if the player busts. You can determine the current score using sum() instead of a for loop since your list only contains integers.

Maybe you can get other ideas to improve your code from the thread mentioned above.

**ThaRealneSS** · Jan 8 '09, 08:49 PM

Originally posted by bvdet

We have a recent blackjack thread that addresses some of your concerns.

blackjack game

Three classes are defined: Card (defines suits and rank, including the Ace), Deck (creates a deck of cards, self.cards contains the Card objects), and BJ. BJ() is the game itself and has methods deal_hand(), hit_hand(), score_hand_BJ() (this is where the Ace is counted as 1 or 11 automatically), play() (the game loop), and play_over() (the game loop is summarized and results are displayed).

Your code has other problems. For example, selecting "H" for hit does not actually give the player a hit because you are using "H" instead of "h" in the if statement. The computer's hand should be automatically hit if below the threshold, but is only hit if the user elects to receive one. There is no check to see if the player busts. You can determine the current score using sum() instead of a for loop since your list only contains integers.

Maybe you can get other ideas to improve your code from the thread mentioned above.

Hi.

Firslty I would like to thank you for spending your time to check out my code, appreciate it buddy :). Secondly, the error with the H/Hit there was, I have slightly fixed and changed and you will see the difference in the new updated code I will upload.

On another note, I have looked at the thread, and even used to the code and played it, and it is very good. But I just do not know how to adapt some of the code from there to mine. One of the main errors with my code is that it keeps going back to the code itself when playing a game (did you come across that?). Do you know how I can fix that? And would you know how I could fix any of the other issues/problems I posted in my first post? I am not that experienced in Python, I know more in VB, so yeah I do not know alot in Python. My friend helped me create this code as I struggled, and he has gone on a vacation so he cannot help me out, which sucks. If you could help me out, I would be very grateful and would appreciate it alot.

Thanks once again.

- ThaRealneSS

Attached Files

realness_updated_blackjack.zip (1.5 KB, 165 views)

**bvdet** · Jan 8 '09, 09:42 PM

I would setup your while loop something like this:

Code:

def play():
    # initialize a results variable
    while True:
        c = raw_input("[D]eal [H]it me [S]tick [Q]uit: ").lower()
        .................
        if c == 'd':
            ..............
        elif c == 'h':
            ..........
        elif c == 's':
            ..........
            # here is where you update results
        elif c == 'q':
            print "Thanks for playing blackjack with the computer!"
            return results

print play()

Here's how I would hit a hand:

Code:

def hit_hand(self, hand, deck):
    hand.append(deck.pop(random.choice(range(len(deck)))))

hit_hand(player_cards, deck)
hit_hand(computer_cards, deck)

This also removes the card from the deck.

**ThaRealneSS** · Jan 8 '09, 10:18 PM

I added the changes (and I know where I added some are wrong, but hey I tried lol), and there are some errors :(. Attached it.

Attached Files

realness_BJ_1.zip (1.4 KB, 120 views)

**bvdet** · Jan 8 '09, 11:05 PM

Originally posted by ThaRealneSS

I added the changes (and I know where I added some are wrong, but hey I tried lol), and there are some errors :(. Attached it.

The comment "# initialize a results variable" meant that YOU need to write some code to initialize an appropriate variable to save the results of the game, maybe a list, nested list or dictionary.

**bvdet** · Jan 8 '09, 11:29 PM

A Card object is just what it says - a card from 52 possibilities.

Code:

>>> Card(2,3)
3 of Clubs
>>> Card(0,12)
Queen of Hearts

A Deck object is a collection of the 52 possible cards.

Code:

>>> Deck()
[Ace of Hearts, 2 of Hearts, 3 of Hearts, 4 of Hearts, 5 of Hearts, 6 of Hearts, 7 of Hearts, 8 of Hearts, 9 of Hearts, 10 of Hearts, Jack of Hearts, Queen of Hearts, King of Hearts, Ace of Diamonds, 2 of Diamonds, 3 of Diamonds, 4 of Diamonds, 5 of Diamonds, 6 of Diamonds, 7 of Diamonds, 8 of Diamonds, 9 of Diamonds, 10 of Diamonds, Jack of Diamonds, Queen of Diamonds, King of Diamonds, Ace of Clubs, 2 of Clubs, 3 of Clubs, 4 of Clubs, 5 of Clubs, 6 of Clubs, 7 of Clubs, 8 of Clubs, 9 of Clubs, 10 of Clubs, Jack of Clubs, Queen of Clubs, King of Clubs, Ace of Spades, 2 of Spades, 3 of Spades, 4 of Spades, 5 of Spades, 6 of Spades, 7 of Spades, 8 of Spades, 9 of Spades, 10 of Spades, Jack of Spades, Queen of Spades, King of Spades]
>>> d = Deck()
>>> d[12]
King of Hearts
>>> len(d)
52
>>> print d
Ace of Hearts
2 of Hearts
3 of Hearts
4 of Hearts
5 of Hearts
6 of Hearts
7 of Hearts
8 of Hearts
9 of Hearts
10 of Hearts
Jack of Hearts
Queen of Hearts
King of Hearts
Ace of Diamonds
2 of Diamonds
3 of Diamonds
4 of Diamonds
5 of Diamonds
6 of Diamonds
7 of Diamonds
8 of Diamonds
9 of Diamonds
10 of Diamonds
Jack of Diamonds
Queen of Diamonds
King of Diamonds
Ace of Clubs
2 of Clubs
3 of Clubs
4 of Clubs
5 of Clubs
6 of Clubs
7 of Clubs
8 of Clubs
9 of Clubs
10 of Clubs
Jack of Clubs
Queen of Clubs
King of Clubs
Ace of Spades
2 of Spades
3 of Spades
4 of Spades
5 of Spades
6 of Spades
7 of Spades
8 of Spades
9 of Spades
10 of Spades
Jack of Spades
Queen of Spades
King of Spades
>>>

All the action takes place in BJ method play(). play() creates a deck of cards and calls other BJ methods to play a game. A Card object is dealt to a hand like this:

Code:

hand.append(deck.cards.pop(random.choice(range(len(deck)))))

Variables hand1 and hand2 represent the hands for Player 1 and Player 2. Player 2 is the dealer (computer). The game results are stored in BJ attribute results, which is a nested list in this format: [[winner, playerhand, dealerhand], [winner, playerhand, dealerhand], [winner, playerhand, dealerhand], ............... ...]

BJ method play_over() determine how many hands were won by whom, and formats the hands for display.

**ThaRealneSS** · Jan 9 '09, 12:20 AM

I appreciate all the help you are giving me, but whenever I put some of it in my code I just get errors and it doesn't work. I may sound like a "n00b" but I guess that's what I am in Python. And I can't fix the error which always makes it go back to the code whenevr a run the program and play it (did you get that too?!?). Thanks once again.

- TheRealneSS

**bvdet** · Jan 9 '09, 01:08 AM

Originally posted by ThaRealneSS

I appreciate all the help you are giving me, but whenever I put some of it in my code I just get errors and it doesn't work. I may sound like a "n00b" but I guess that's what I am in Python. And I can't fix the error which always makes it go back to the code whenevr a run the program and play it (did you get that too?!?). Thanks once again.

- TheRealneSS

Maybe I don't understand what you mean by "go back to the code". I had no problem exiting the script. When I enter a "Q", it exits.

**ThaRealneSS** · Jan 9 '09, 01:25 AM

Like when I run the code and play a game, for example if I press the "Q" key to exit, then I will see the CMD shell window pop up for like half a second, and then it will take me back to my code (Python Editor). For me to be able to continute using my code I have to minimise the Python Editor and go back onto te Python Shell. Get what I mean now?

- ThaRealneSS

**bvdet** · Jan 9 '09, 03:02 AM

Originally posted by ThaRealneSS

Like when I run the code and play a game, for example if I press the "Q" key to exit, then I will see the CMD shell window pop up for like half a second, and then it will take me back to my code (Python Editor). For me to be able to continute using my code I have to minimise the Python Editor and go back onto te Python Shell. Get what I mean now?

- ThaRealneSS

Not really. Are you running the script from your Python editor or from the command prompt?

**ThaRealneSS** · Jan 9 '09, 09:59 AM

Originally posted by bvdet

Not really. Are you running the script from your Python editor or from the command prompt?

From the Python Editor.

Blackjack Code Help!!

Blackjack Code Help!!

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment