Aaron Brady <cast...pigmail .comwrote:
The thought police will come and get you.
You are doing things by "side effect"!
You are using a global called "stuff"!
You are relying on an implementation
detail!
While their cudgels are bouncing off
your skull, they will scream the above three
lines into your swiftly swelling ears!
I suggest you write;
while True:
stuff = calculate_stuff ()
if stuff < 0.00005:
break
quickly, to avoid the pain!
It may be too late though - even the
above sanitised version is still too
tightly coupled - how must
calculate_stuff know where to find
the inputs for its calculation?
You are gonna bleed!
:-)
- Hendrik
--
No good deed will go unpunished.
>while 1:
calculate_stuff ( )
if stuff < 0.00005:
break
calculate_stuff ( )
if stuff < 0.00005:
break
You are doing things by "side effect"!
You are using a global called "stuff"!
You are relying on an implementation
detail!
While their cudgels are bouncing off
your skull, they will scream the above three
lines into your swiftly swelling ears!
I suggest you write;
while True:
stuff = calculate_stuff ()
if stuff < 0.00005:
break
quickly, to avoid the pain!
It may be too late though - even the
above sanitised version is still too
tightly coupled - how must
calculate_stuff know where to find
the inputs for its calculation?
You are gonna bleed!
:-)
- Hendrik
--
No good deed will go unpunished.