Is this code correct

[tharindu96]

can someone tell me if this code is correct i'm getting "not".

$query = "SELECT `id` FROM `users` WHERE `username`='$username' AND `password`='$passhash'";
	if($query_run = mysql_query($query)) {
			echo 'ok.';
		}else{
			echo 'not.';	
		}

[Rabbit]

= is the assignment operator, == is the comparison operator.

[Dormilich]

if there is a mysql error you can get it with mysql_error().