inserting & deleting multiple records in php

[ravi951]

hi all,
i have written a script for deleting more than one records using check box.
but it is not working.below is the code ...

<script>
function fundel(sno)
{
rv=confirm("u want to delete");
if(rv==true)
{
location="delete.php?seno="+sno;
}
}
</script>
<form method="post" action="delrec.php">
<table border='1'>
<?php
mysql_connect("localhost","****","****");
mysql_select_db("test");
$data=mysql_query("select * from emp");
while($rec=mysql_fetch_row($data))
{
echo"<tr><td><input type='checkbox' name=$rec[2]'
value='$rec[2]'><td>$rec[0]<td>$rec[1]<td>$rec[2]<td><input type='button' value='delete'
onclick='fundel($rec[2])'>";
}
?>
</table>
<input type='submit' value='delrec'>
</form>

below ids the delrec.php

/*<?php
$qs=$_REQUEST['seno'];
mysql_connect("localhost","****","****");
mysql_select_db("test");
mysql_query("delete from emp where sno=$qs");
header('location:getrec.php");
?>*/
<script>
function delrec(sno)
{
rv=confirm("u want to delete");
if(rv==true)
{
location="delete.php?seno="+sno;
}
}
</script>

also is the delete.php.

<?php
$qs=$_REQUEST['seno'];
mysql_connect("localhost","****","****");
mysql_select_db("test");
mysql_query("delete from emp where sno=$qs");
header("location:getrec.php");
?>
/*<script>
function delrec(sno)
{
rv=confirm("u want to delete");
if(rv==true)
{
location="delete.php?seno="+sno;
}
}
</script>
*/

also i want to insert values of three fields using php code.
i have written the code.when i click the insert button it should get inserted
into database....
below is the code for insert function..

<table width="300" border="0" align="center" cellpadding="0" cellspacing="1">
<tr>
<td><form name="form1" method="post" action="ins.php">
<table width="100%" border="0" cellspacing="1" cellpadding="3">
<tr>
<td colspan="3"><strong>Insert Data Into mySQL Database </strong></td>
</tr>
<tr>
<td width="71">Name</td>
<td width="6">:</td>
<td width="301"><input name="name" type="text" id="name"></td>
</tr>
<tr>
<td>Lastname</td>
<td>:</td>
<td><input name="lastname" type="text" id="lastname"></td>
</tr>
<tr>
<td>Email</td>
<td>:</td>
</tr>
<tr>
<td colspan="3" align="center"><input type="submit" name="Submit" value="Submit"></td>
</tr>
</table>
</form>
</td>
</tr>
</table>

also the ins.php.

<?php

/*$host="localhost"; // Host name 
$username=""; // Mysql username 
$password=""; // Mysql password 
$db_name="test"; // Database name 
$tbl_name="test_mysql"; // Table name*/

// Connect to server and select database.
mysql_connect("localhost", "****", "****")or die("cannot connect"); 
mysql_select_db("test")or die("cannot select DB");

// Get values from form 
$empno=$_POST['empno'];
$empname=$_POST['empname'];
$desig=$_POST['desig'];

// Insert data into mysql 
$sql="INSERT INTO emp(empno, empname, desig)VALUES('$empno', '$empname', '$desig')";
$result=mysql_query($sql);

// if successfully insert data into database, displays message "Successful". 
if($result){
echo "Successful";
echo "<BR>";
echo "<a href='insert.php'>Back to main page</a>";
}

else 
{
echo "ERROR";
}
// close connection 
mysql_close();
?>

i want all these to be integrated into one form so that i can easily insert,delete using php
kindly tell me how to do it....

[Dormilich]

"not working" is a kind of vague description. what is not working? are there any error messages? do you have error messages enabled?

PS. your code is highly susceptible to SQL Injection. imagine someone would type in the address bar: http://yourdomain.exam ple.org/delete.php?seno =1+or+1=1 (which would delete all your data)

[ravi951]

i mean i have selected three or more records using checkbox and clicked the delete button but it is not deleting the records.
what is the problem with fundel() in the above code..
dont no what went wrong..

[Dormilich]

there might be issues with the generated HTML code.

if you click the delete button, you can only delete one entry (that’s how you defined the JS function)

if you click the form submit button, you only have the last (document-wise) checkbox to delete.