Terms and Conditions Form, 1 Checkbox redirect to another page

[david ashby]

Hi I have a basic form, all it has on it is a checkbox with terms and conditions, the user has to check the box to say I agree, the problem I am having is the page is echoing the correct information out but is not redirecting the user if they check the box.

The Php code is in include statement in the form page which is layed out via css etc etc.

The code I have is

$submit = $_POST['submit'];
$agree = $_POST['agree'];

if (isset ($_POST['agree'])) {

	echo "<h3>You agree to our terms</h3>";
	header('Refresh: 10; URL=searcher.php');
	
} else echo "<h3>You Disagree, you must agree before using our database</h3>";

I have also tried

$submit = $_POST['submit'];
$agree = $_POST['agree'];

if (isset ($_POST['agree'])) {

	echo "<h3>You agree to our terms</h3>";
	header('Location: searcher.php');
	
} else echo "<h3>You Disagree, you must agree before using our database</h3>";

I have tried using the variables set but nothing works when I do

Can anyone tell me where I am going wrong?

Be grateful for some help as I am getting nowhere fast with this.

Thanks in advance.

[Sudaraka]

1. Make sure your form is set to submit using HTTP POST, not GET. (method="post")
2. Make sure you checkbox is named "agree" (name="agree") and have some non-empty value (value="AGREED" )
3. In the back-end code check if the value is empty or not.

if(empty($_POST['agree'])) {
	//Not agreed
}
else {
	//Agreed
}

[david ashby]

Thanks for the reply but I am missing something, what you have given me is half working i9n that it redirects to the page required but it also redirects if checkbox not ticked, what have I missed?

<form id="form1" name="form1" method="post" action="search.php">
<label for="agree">Agree</label>
          <input type="checkbox" name="agree" id="agree" />

<input type="submit" name="submit" id="submit" value=" Agree " />

The page with the form is search.php so it is posting back to itself

the php script included in the form is

<?php include 'php/termscond.php'; ?>

and the script is as follows now

if(empty($_POST['agree'])) {
	
    echo "<h3>You must agree before accessing our database</h3>";
}
else {
    header('Location: searcher.php');
}

The header is not working although the search.php and searcher.php are at same level in directory in same folder.

Thanks in advance for your help

[Sudaraka]

Code you have posted above works fine. Maybe some other part of the code is interfering with the redirection.

Here's what I tested:
search.php

<?php include 'termscond.php'; ?>
<form id="form1" name="form1" method="post" action="search.php">
<label for="agree">Agree</label>
          <input type="checkbox" name="agree" id="agree" />

<input type="submit" name="submit" id="submit" value=" Agree " />
</form>

termscond.php

<?php
if(empty($_POST['agree'])) {

    echo "<h3>You must agree before accessing our database</h3>";
}
else {
    header('Location: searcher.php');
}

[david ashby]

So in your test when you did not check the box you were advised to check or you could not use the search facility but you were kept on the terms page?

When you checked the box you were redirected?

[Sudaraka]

yes, it only goes to the searcher.php if the checkbox is checked.

[david ashby]

Would it be possible for you to just have a quick look at the pages concerned, to see if you can spot why it is not working for me then please?

[Sudaraka]

Sure, Please post the complete and latest code you are trying out.

[david ashby]

Link to search page

The php code is exactly what you suggested earlier, I just cannot seem to work out why I cannot get it working especially as you have said it worked for you.

[Sudaraka]

Your HTML form seems to be ok. I think the problem might be in http://www.da-ict.co.uk/php/termscond.php
Please post the complete PHP code of that file.

[david ashby]

<?php 
if(empty($_POST['agree'])) {
	
    echo "<h3>You must agree before accessing our database</h3>";
}
else {
    header('Location: searcher.php');
}


?>

Thanks for this, especially when you said you had it working it threw me even more.

[Sudaraka]

Hmm, that's the same code I tried on my local server and it worked. But I clearly see it's not working on yours.

Can you add error_reporting (E_ALL); on top of all the pages involved in this process and see if you are getting any errors?
And, instead of the redirect echo some text and see of the program flow reaches that section.

Oh, and add a value to your check box.

<input type="checkbox" id="agree" name="agree" value="yes">

[david ashby]

As the rest of the site is being tested I have re-saved the terms and conditions page under http://www.da-ict.co.uk/searchtcs.php until the issue is resolved.

I have put the value="yes" in the checkbox.

If I echo text out instead of the redirect the action works, the correct text is echoed out depending on the condition so does that point to the header('Locatio n: searcher.php'); of the php script?

If you look at http://www.da-ict.co.uk/searchtcs.php I have just left echo text statements in place depending on the checkbox condition the correct one is output but when I put the header back in that just doesnt work.

[david ashby]

The error log shows the following

[14-Mar-2011 13:29:03] PHP Warning:  Cannot modify header information - headers already sent by (output started at /home/daictcou/public_html/searchtcs.php:4) in /home/daictcou/public_html/php/termscond.php on line 22
[14-Mar-2011 13:29:08] PHP Warning:  Cannot modify header information - headers already sent by (output started at /home/daictcou/public_html/searchtcs.php:4) in /home/daictcou/public_html/php/termscond.php on line 22
[14-Mar-2011 13:31:00] PHP Warning:  Cannot modify header information - headers already sent by (output started at /home/daictcou/public_html/searchtcs.php:4) in /home/daictcou/public_html/php/termscond.php on line 22
[14-Mar-2011 13:31:31] PHP Warning:  Cannot modify header information - headers already sent by (output started at /home/daictcou/public_html/searchtcs.php:4) in /home/daictcou/public_html/php/termscond.php on line 22
[14-Mar-2011 13:31:39] PHP Warning:  Cannot modify header information - headers already sent by (output started at /home/daictcou/public_html/searchtcs.php:4) in /home/daictcou/public_html/php/termscond.php on line 22
[14-Mar-2011 13:36:04] PHP Warning:  Cannot modify header information - headers already sent by (output started at /home/daictcou/public_html/searchtcs.php:4) in /home/daictcou/public_html/php/termscond.php on line 22
[14-Mar-2011 13:36:08] PHP Warning:  Cannot modify header information - headers already sent by (output started at /home/daictcou/public_html/searchtcs.php:4) in /home/daictcou/public_html/php/termscond.php on line 22

This is obviously when I am using the header rather then the echo that is currently on the page.

[Sudaraka]

When you redirect using header() there shouldn't be any output generated before that.
Make sure you don't have any echo or HTML output before the redirect.

You can try buffering the output to avoid this http://php.net/manual/en/function.ob-start.php

also place an exit() right after the header()