Internet logging using c# & perl cgi script

[alag20]

Hi Guys,
Sorry for duplicate posting as this Question refers to both c# and perl cgi script on the net, so please help.

Here is the original post

http://bytes.com/topic/c-sharp/answers/870412-internet-logging-using-c-perl-cgi-script#post3493381

which contains the perl cgi script and c# code i am using.


Please help - any help will be highly appreciated.

[RonB]

There's nothing in the Perl script that would cause it to duplicate the log entries so I'm not sure what you're wanting from us, unless you're wanting us to help you cleanup the very poorly written script.

[alag20]

Any help to clean and make it better would be highly appreciated. Also can we return some text to the browser so that it shows some status from the script?

Sorry i am very new at perl. i am more experienced with .Net but the server doesnt support it:(

[RonB]

The only thing your Perl script does is write a log entry of the passed in cgi params each time it's called. I don't see why you're not doing that in the c# program.

I cleaned up the script and left out the parts that didn't really do anything.

#!c:/Perl/bin/Perl.exe 

use strict;
use warnings;
use POSIX 'strftime';
use CGI ':standard';
use Fcntl ':flock';

my $counterfile = 'D:/output.txt';
open my $FILE, '>>', $counterfile or die "Can't open '$counterfile' file $!";
flock($FILE, LOCK_EX); # blocking write lock

my @fields;
$fields[0]  = param('username');
$fields[1]  = param('contract');
$fields[2]  = param('status');
$fields[3]  = param('file'};
$fields[4]  = $ENV{'REMOTE_ADDR'};
$fields[5]  = strftime("%m/%d/%y %H:%M:%S", gmtime(time));
$fields[6]  = $ENV{'HTTP_USER_AGENT'}
$fields[7]  = param('iver');
$fields[8]  = param('sys');
$fields[9]  = param('sysloc'};
$fields[10] = param('lang');
$fields[11] = param('OpSys');

print $FILE join(',', @fields), "\n";

flock(FILE, LOCK_UN);
close $FILE;

I don't know c# but I assume that it captures the STDOUT stream from the Perl script. So, if you need to pass back anything to the c# program, just print to the STDOUT handle, which is the default when using the Perl print function.

The die statement in the open call sends its output to the STDERR handle.

[numberwhun]

My first bit of advice is to include the following into every Perl script:

use strict;
use warnings;

You will find that there are a number of people here who won't touch your script unless you have these in there. By using them, you will be able to correct a lot of the simple coding mistakes that beginners make and allow us to better tackle the real issue(s) at hand.

As for your Perl script (this is before looking at Ron's version, I don't see anything in your script that says "I am CGI" other than your reference of the ENV hash. To output to the screen you will really need to use the CGI module as Ron has done.

There are plenty of tutorials on CGI in Perl on the internet, you just have to Google them. I would also highly recommend you get a copy of "Learning Perl'" from O'Reilly. It is a wonderful introduction into the world of Perl and I always keep a copy within reach.

Regards,

Jeff