Problem in Perl program

[ashootoshverma]

Hi Everyone,

I am new in perl programming can anyone help me to give a right way to do in this program
"Zip all .* file from a one windows directory to another directory."

Here is my code.

[CODE=perl]#!\usr\bin\perl
use Archive::Zip qw(:ERROR_CODES :CONSTANTS);
use File::Copy;
$Inpath = "M:\\SAPCONV\\S taging\\scripts \\";
print ".pl files in $Inpath are:\n";
opendir(DIR, $Inpath) or die "Can't open $Inpath: $!";
while( defined ($file = readdir DIR) ) {
print "glob param: $file\n" if -T "$Inpath/$file";
}
closedir(DIR);
$OutPath = "G:\\sysouts\\" ;
$tempdir = $Inpath . "scripts\\temp\ \";
$zipfile = "scripts.zi p";
chdir $InPath;
@FileList = glob($file);
my $zip = Archive::Zip->new();

foreach (@FileList) {
$FilePathName = $_;
@PathnameParts = split /\\/, $FilePathName;
$ListCount = @PathnameParts;
$FileName = @PathnameParts[$ListCount-1];

print "Adding File...." . $FileName . "\n";

$zip->addFile( $FileName )
or do {
warn "Can't add file $FileName, $!\n";

}
}

my $status = $zip->writeToFileNam ed($OutPath.$zi pfile);

if ($status == AZ_OK) {
print "Zipping completed successfully\n" ;

} else {
print "Zipping completed with errors\n";

}[/CODE]

[numberwhun]

Hi Everyone,

I am new in perl programming can anyone help me to give a right way to do in this program
"Zip all .* file from a one windows directory to another directory."

Here is my code.

[CODE=perl]#!\usr\bin\perl
use Archive::Zip qw(:ERROR_CODES :CONSTANTS);
use File::Copy;
$Inpath = "M:\\SAPCONV\\S taging\\scripts \\";
print ".pl files in $Inpath are:\n";
opendir(DIR, $Inpath) or die "Can't open $Inpath: $!";
while( defined ($file = readdir DIR) ) {
print "glob param: $file\n" if -T "$Inpath/$file";
}
closedir(DIR);
$OutPath = "G:\\sysouts\\" ;
$tempdir = $Inpath . "scripts\\temp\ \";
$zipfile = "scripts.zi p";
chdir $InPath;
@FileList = glob($file);
my $zip = Archive::Zip->new();

foreach (@FileList) {
$FilePathName = $_;
@PathnameParts = split /\\/, $FilePathName;
$ListCount = @PathnameParts;
$FileName = @PathnameParts[$ListCount-1];

print "Adding File...." . $FileName . "\n";

$zip->addFile( $FileName )
or do {
warn "Can't add file $FileName, $!\n";

}
}

my $status = $zip->writeToFileNam ed($OutPath.$zi pfile);

if ($status == AZ_OK) {
print "Zipping completed successfully\n" ;

} else {
print "Zipping completed with errors\n";

}[/CODE]

So, if you run the code, are you getting any errors? Before anyone here touches this code though, you are going to have to include the pragmas "use strict" and "use warnings" and get the usual bugs out of the way first.

REgards,

Jeff

[ashootoshverma]

Thanks!
Jeff,

I used use stirct and use warnings
I got so many error like ,So please help me to traceout from this script.
Thanks in advance.

So, if you run the code, are you getting any errors? Before anyone here touches this code though, you are going to have to include the pragmas "use strict" and "use warnings" and get the usual bugs out of the way first.

REgards,

Jeff

[nithinpes]

Thanks!
Jeff,

I used use stirct and use warnings
I got so many error like ,So please help me to traceout from this script.
Thanks in advance.

When you use strict pragma, you have to define all your variables as local to the script using 'my' keyword. Apart from that, I have made few changes in while loop, by including next five lines inside the loop. This worked for me.

[CODE=perl]
#!\usr\bin\perl
use strict;
use warnings;
use Archive::Zip qw(:ERROR_CODES :CONSTANTS);

my ($file,$zipfile ,$zip);
my @FileList;
my $tempdir;

my $Inpath = "D:\\SAP\\scrip ts\\";
my $OutPath = "D:\\sysouts\\" ;
print "The files in $Inpath are:\n";
opendir(DIR, $Inpath) or die "Can't open $Inpath: $!";
while( defined ($file = readdir DIR) ) {
print "glob param: $file\n" if -T "$Inpath/$file";

$tempdir = $Inpath . "scripts\\temp\ \";
$zipfile = "scripts.zi p";
chdir $Inpath;
push @FileList,$file if($file=~/\.pl/); ### add only files with .pl extension
}
closedir(DIR);
$zip = Archive::Zip->new();
foreach (@FileList) {
my $FilePathName = $_;
my @PathnameParts = split /\\/, $FilePathName;
my $ListCount = @PathnameParts;
my $FileName = $PathnameParts[$ListCount-1];

print "Adding File.... $FileName \n";

$zip->addFile( $FileName )
or do {
warn "Can't add file $FileName, $!\n";

}
}

my $status = $zip->writeToFileNam ed($OutPath.$zi pfile);

if ($status == AZ_OK) {
print "Zipping completed successfully\n" ;

} else {
print "Zipping completed with errors\n";

}
[/CODE]

[nithinpes]

Forgot to mention the reason for including the lines inside while loop. Well, you can define $tempdir and $zipfile outside the while loop and that is the best way of doing it to avoid unnecessary variable assignment with each iteration. I included these two lines by mistake.
But the line of concern is where you define @FileList. If you define it outside, $file will be containing the last variable(last file) read and hence you can't build the filelist.

[ashootoshverma]

First thanks for your help second it didn't extract all .pl file from different folder
those in directory M:\\ .Actually M:\\ contain some file like .pl as well as some folders .And every folder have .pl files in it.

When you use strict pragma, you have to define all your variables as local to the script using 'my' keyword. Apart from that, I have made few changes in while loop, by including next five lines inside the loop. This worked for me.

[CODE=perl]
#!\usr\bin\perl
use strict;
use warnings;
use Archive::Zip qw(:ERROR_CODES :CONSTANTS);

my ($file,$zipfile ,$zip);
my @FileList;
my $tempdir;

my $Inpath = "D:\\SAP\\scrip ts\\";
my $OutPath = "D:\\sysouts\\" ;
print "The files in $Inpath are:\n";
opendir(DIR, $Inpath) or die "Can't open $Inpath: $!";
while( defined ($file = readdir DIR) ) {
print "glob param: $file\n" if -T "$Inpath/$file";

$tempdir = $Inpath . "scripts\\temp\ \";
$zipfile = "scripts.zi p";
chdir $Inpath;
push @FileList,$file if($file=~/\.pl/); ### add only files with .pl extension
}
closedir(DIR);
$zip = Archive::Zip->new();
foreach (@FileList) {
my $FilePathName = $_;
my @PathnameParts = split /\\/, $FilePathName;
my $ListCount = @PathnameParts;
my $FileName = $PathnameParts[$ListCount-1];

print "Adding File.... $FileName \n";

$zip->addFile( $FileName )
or do {
warn "Can't add file $FileName, $!\n";

}
}

my $status = $zip->writeToFileNam ed($OutPath.$zi pfile);

if ($status == AZ_OK) {
print "Zipping completed successfully\n" ;

} else {
print "Zipping completed with errors\n";

}
[/CODE]

[nithinpes]

First thanks for your help second it didn't extract all .pl file from different folder
those in directory M:\\ .Actually M:\\ contain some file like .pl as well as some folders .And every folder have .pl files in it.

Well, you had not mentioned that in your previous description. In that case, you can check for directories inside the main folder and further read from these sub-directories.

[CODE=perl]
#!\usr\bin\perl
use strict;
use warnings;
use Archive::Zip qw(:ERROR_CODES :CONSTANTS);

my ($zipfile,$zip) ;
my @FileList;
my $tempdir;
my @subdir;

my $Inpath = "D:\\SAP\\scrip ts\\";
my $OutPath = "D:\\sysouts\\" ;
print ".pl files in $Inpath are:\n";
opendir(DIR, $Inpath) or die "Can't open $Inpath: $!";
while( defined (my $file = readdir DIR) ) {
print "glob param: $file\n" if -T "$Inpath/$file";

push @subdir,$file if(-d "$Inpath\\$file "); ##taking out sub-folders

push @FileList,$file if($file=~/\.pl/);


}
closedir(DIR);

foreach(@subdir ) ##read from sub-folders
{
next if($_ =~/^\.*$/); ## remove . and ..
opendir(SUB, "$Inpath/$_") or die "Can't open $Inpath: $!";
while( defined (my $subfile = readdir SUB) ) {
push @FileList,$subf ile if($subfile=~/\.pl/);
}
closedir(SUB);
}

$tempdir = $Inpath . "scripts\\temp\ \";
$zipfile = "scripts.zi p";
$zip = Archive::Zip->new();

foreach (@FileList) {
my $FilePathName = $_;
my @PathnameParts = split /\\/, $FilePathName;
my $ListCount = @PathnameParts;
my $FileName = $PathnameParts[$ListCount-1];

print "Adding File.... $FileName \n";

$zip->addFile( $FileName )
or do {
warn "Can't add file $FileName, $!\n";

}
}

my $status = $zip->writeToFileNam ed($OutPath.$zi pfile);

if ($status == AZ_OK) {
print "Zipping completed successfully\n" ;

} else {
print "Zipping completed with errors\n";

}

[/CODE]

[nithinpes]

Also, the above code will work for one level of hierarchy i.e. folder having perl files and sub-folders having perl files. If the sub-folders have further sub-folders and you want to traverse entire directory tree, make use of File::Find module.

[ashootoshverma]

Hi Thanks again,
But the error message what I got is
Adding file .........xyz.pl
Cann't add file xyz.pl~ No such file or directory

[ashootoshverma]

Hi All,

Can anyone help me to findout solution of my problem because its almost a long time for my problem put in forum.

Hi Thanks again,
But the error message what I got is
Adding file .........xyz.pl
Cann't add file xyz.pl~ No such file or directory

[nithinpes]

Hi All,

Can anyone help me to findout solution of my problem because its almost a long time for my problem put in forum.

Try this:

[CODE=perl]
#!\usr\bin\perl
use strict;
use warnings;
use Archive::Zip qw(:ERROR_CODES :CONSTANTS);

my ($zipfile,$zip) ;
my @FileList;
my $tempdir;
my @subdir;

my $Inpath = "D:\\SAP\\scrip ts\\";
my $OutPath = "D:\\sysouts\\" ;
print ".pl files in $Inpath are:\n";
opendir(DIR, $Inpath) or die "Can't open $Inpath: $!";
while( defined (my $file = readdir DIR) ) {
print "glob param: $file\n" if -T "$Inpath/$file";

push @subdir,$file if(-d $Inpath.$file); ##taking out sub-folders

push @FileList,$Inpa th.$file if($file=~/\.pl/);


}
closedir(DIR);

foreach(@subdir ) ##read from sub-folders
{
next if($_ =~/^\.*$/);
opendir(SUB, "$Inpath/$_") or die "Can't open $Inpath: $!";
while( defined (my $subfile = readdir SUB) ) {
push @FileList,$Inpa th."$_\\$subfil e" if($subfile=~/\.pl/); }
closedir(SUB);
}

$tempdir = $Inpath . "scripts\\temp\ \";
$zipfile = "scripts.zi p";
$zip = Archive::Zip->new();

foreach (@FileList) {
my $FileName =$_;
print "Adding File.... $FileName \n";

$zip->addFile( $FileName )
or do {
warn "Can't add file $FileName, $!\n";

}
}

my $status = $zip->writeToFileNam ed($OutPath.$zi pfile);

if ($status == AZ_OK) {
print "Zipping completed successfully\n" ;

} else {
print "Zipping completed with errors\n";

}
[/CODE]