prompt not working rock paper scissors odin project

**Luuk** · Mar 17 '18, 06:08 PM

On line #15 you are missing an 'if' (after 'else')
On line #22 you are missing an '{'

After changing above two typo's, you'll get a question asked about "Do you choose rock, paper or scissors?"

**Luuk** · Mar 17 '18, 06:20 PM

Also there is something called the scope of a variable, Google for it, an look at what this code does:

Code:

var a = 1;

function one() {
          var a=2;
          alert(a);
}

one();
alert(a);

It gives two alerts, first '2', than '1'.....
It's important to understand why the second alert returns '1'!

**as1000** · Mar 17 '18, 08:07 PM

Thank you for your answer. I made the changes but it still isn't working.

Code:

<!DOCTYPE html>
<html>
<head>
  <script>
function askUser(){
 var playerSelection=prompt("Do you choose rock, paper or scissors?")}
 
askUser()
  
   
function computerPlay(){
  let computerSelection = Math.random() *3;
  if (computerSelection===0) {
      computerSelection = "rock";
      } else if(computerSelection ===1); {
        computerSelection = "scissors"
      } else {computerSelection = "paper"
             }
}
    
    
function singleRound(playerSelection, computerSelection){
    playerSelection = playerSelection.toLowerCase()
    if (playerSelection=="scissors" && computerSelection=="scissors") {
return "It's a tie!"}

    else if 
    (playerSelection=="scissors" && computerSelection=="rock"){
return "Rock bests scissors"}
  
    else if (playerSelection=="scissors" && computerSelection=="paper")
    {return"You win. Scissors beats paper"} 
     else if
  (playerSelection=="paper" && computerSelection=="scissors"){
return "I win. Scissors beats paper!"}
    
    else if
(playerSelection=="paper"/i && computerSelection=="rock") {
return "You win! paper beats rock!"}
    
    else if (playerSelection=="paper" && computerSelection=="paper")
    {return "Paper and paper are a tie!"}
    
    else if (playerSelection=="rock" && computerSelection=="paper"){
return "I win. Paper beats rock."}

    else if (playerSelection=="rock" && computerSelection=="scissors"){
return "You win. Rock beats scissors."
}
    else if (playerSelection=="rock" && computerSelection=="rock"){
return "Rock and rock is a tie."
    }




  </script>
  
</head>
<body>
  
  
</body>
</html>

**Luuk** · Mar 18 '18, 03:43 PM

Did you read my second post?

If not, or if you did not understand, try adding this line between lines #22 en #23

Code:

alert(playerSelection); alert(computerSelection);

You will see that this code is never executed, and if it is executed that these variabled will not have the value you expect them to have ...

**gits** · Mar 19 '18, 08:49 AM

aside the mentioned scope issues - there are even more syntax errors in the code - that could be much better spotted if the code was written somehow with a clean alignment.

line 15: semicolon breaks the conditional statement
line 38: whats with the /i there?

last function body missing a closing curly bracket.

**as1000** · Mar 19 '18, 10:04 PM

Thanks. I moved the variables outside the functions but here is still no prompt.

Code:

<!DOCTYPE html>
<html>
<head>
  <script>
 
var playerSelection=prompt("Do you choose rock, paper or scissors?")}
let computerSelection = Math.random() *3;

  
   
function computerPlay(){

  if (computerSelection===0) {
      computerSelection = "rock";
      } else if(computerSelection ===1) {
        computerSelection = "scissors"
      } else {computerSelection = "paper"
             }
}
    
    
function singleRound(playerSelection, computerSelection){
    playerSelection = playerSelection.toLowerCase()
    if (playerSelection=="scissors" && computerSelection=="scissors") {
return "It's a tie!"}

    else if 
    (playerSelection=="scissors" && computerSelection=="rock"){
return "Rock bests scissors"}
  
    else if (playerSelection=="scissors" && computerSelection=="paper")
    {return"You win. Scissors beats paper"} 
     else if
  (playerSelection=="paper" && computerSelection=="scissors"){
return "I win. Scissors beats paper!"}
    
    else if
(playerSelection=="paper"/i && computerSelection=="rock") {
return "You win! paper beats rock!"}
    
    else if (playerSelection=="paper" && computerSelection=="paper")
    {return "Paper and paper are a tie!"}
    
    else if (playerSelection=="rock" && computerSelection=="paper"){
return "I win. Paper beats rock."}

    else if (playerSelection=="rock" && computerSelection=="scissors"){
return "You win. Rock beats scissors."
}
    else if (playerSelection=="rock" && computerSelection=="rock"){
return "Rock and rock is a tie."
    }
    }




  </script>
  
</head>
<body>
  
  
</body>
</html>

**Luuk** · Mar 19 '18, 10:15 PM

When do you think the code on line #6 (var playerSelection =....) is getting executed?

Because you are not getting the prompt, does mean that this line is not executed.

I suggest to surround line #6 and #7 with:

Code:

function init() {
  var playerSelection=prompt("Do you choose rock, paper or scissors?")}
  let computerSelection = Math.random() *3;
}

and change line #61 to

Code:

body onload="init();"

**gits** · Mar 20 '18, 08:40 AM

well - there are still syntax errors in the code:

line 6: closing curly bracket invalidates parsing of the script

line 38: the /i is still there but useless

usually the above hint is correct to start the script in the onload-event of the page since you probably want to output something on the page using the DOM. The prompt actually isnt executed at the moment just because of the syntax error in line 6. But even if it would be executed the other methods arent called at any point - so you need to call them when they should operate.

I suggest to open the browsers developer console when you test your code - that way you can avoid posting all the obvious errors and fix your code faster instead of waiting for replies here. Then you can post back with more detailed questions - if its still not working as you expect it to work.

**as1000** · Mar 20 '18, 11:03 PM

Hi. Thanks. The prompt worked once. I then called the functions and it stopped working. I then got two errors-1 semicolon after calling a function and one saying that init is not defined.

Code:

<!DOCTYPE html>
<html>
<head>
  <script>
 
function init(){
 var playerSelection=prompt("Do you choose rock, paper or scissors?")
 let computerSelection = Math.random() *3;
 }
  
   
computerPlay(){
  
  if (computerSelection===0) {
      computerSelection = "rock";
      } else if(computerSelection ===1) {
        computerSelection = "scissors"
      } else {computerSelection = "paper"
             }
}

computerPlay(computerSelection);
    
    
function singleRound(playerSelection, computerSelection){
    playerSelection = playerSelection.toLowerCase()
    if (playerSelection=="scissors" && computerSelection=="scissors") {
return "It's a tie!"}

    else if 
    (playerSelection=="scissors" && computerSelection=="rock"){
return "Rock bests scissors"}
  
    else if (playerSelection=="scissors" && computerSelection=="paper")
    {return"You win. Scissors beats paper"} 
     else if
  (playerSelection=="paper" && computerSelection=="scissors"){
return "I win. Scissors beats paper!"}
    
    else if
(playerSelection=="paper" && computerSelection=="rock") {
return "You win! paper beats rock!"}
    
    else if (playerSelection=="paper" && computerSelection=="paper")
    {return "Paper and paper are a tie!"}
    
    else if (playerSelection=="rock" && computerSelection=="paper"){
return "I win. Paper beats rock."}

    else if (playerSelection=="rock" && computerSelection=="scissors"){
return "You win. Rock beats scissors."
}
    else if (playerSelection=="rock" && computerSelection=="rock"){
return "Rock and rock is a tie."
    }
    }
    
singleRound(computerSelection, playerSelection);



  </script>
  
</head>
<body onload="init();">
  
  
</body>
</html>

**gits** · Mar 21 '18, 10:03 AM

ok - did you have a look at the developer tools? it tells you that it breaks in your line 12 due to a syntax error again. you missing the function keyword there.

and then of course it will complain that init is not defined since the script couldn't be parsed correctly before.

you need to understand what exactly happens when you run a webpage together with javascript. let me summarize it in a few simplified words:

the html doument basically is rendered by the browser - which itself basically builds a in-memory model of that page and provides a (javascript-)API to that in-memory representation of the document. this representation is usually referred to as the DOM (document object model). With the mentioned API its possible to operate on that DOM with javascript to dynamically modify that document - this - in very simplified words - includes appearance and even behavior of the page or even just portions of it. behavior is in most cases triggered by events - like clicking on something, changing a value in an input element or even just loading a page and wait for its DOM to be fully ready created by the browser.

Look at your page now - the browser starts reading it from the top to the bottom - and starts interpreting it to display the html-page. since usually you want to output something in a div or such - you can access the DOM safely when the page is fully interpreted and the DOM is fully created. At that point the onload-event of the document is fired - and you use it to call your init-function.

when you call other functions in the script block directly like you did in your code - those are executed right away when the browser interprets the page - thus everything that you call there is executed before! the onload-event is triggered - or at least it is not safe to rely on something that you expect to have happened before. So you would need to modify your code to have a reliable execution chain of commands that you want to have executed.

I suggest to dig more into what i told you here - since those things are the minimum things to know about when you want to do something right with javascript. Its no rocket-science so you can do it - and you wouldn't drive around a truck on the streets as well without learning some basics before.

prompt not working rock paper scissors odin project

prompt not working rock paper scissors odin project

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment