Problem with jquery script on firefox works fine on IE

[Alvaro Louzada]

i m using this script to expand a DIV

function ShowDiv(Div-id) {
if (false == jQuery(Div-id).is(':visible')) {
jQuery(Div-id).show(250);
}
else {
jQuery(Div-id).hide(250);
}
}

//and the link is like this

onclick="ShowDiv(Div-1)"

onclick="ShowDiv(Div-2)"

on firefox giveme a erro Div-1 is not defined

[Samishii23]

First off, you can not use the hyphen symbol (-) as apart of a variable name. Its a reserved character for subtraction. That is most likely why Firefox is giving the variable not declared error.

Plus: This may be a lot easier:

function ShowDiv(id) {
  $(id).show();
  // and for hiding
  $(id).hide();
  }

Also, jQuery provides the toggle() function which automatically checks to see if the element matched is hidden or shown and will show or hide the element proper.

$(id).toggle();

[Alvaro Louzada]

with the last solution dont work..

let me put my fixed code but just work on IE

function ShowDiv(Div_id) {
if (false == jQuery(Div_id).is(':visible')) {
jQuery(Div_id).show(250);
}
else {
jQuery(Div_id).hide(250);
}
}

then i have

//link 

onclick="ShowDiv(Div_1)" 

// the i have the oculted div
<div class="commentformBlock Light11 Orange1" id="Div_1" style="display: none;">

On IE on the first click shows div, if i click again fade div

on firefox not works.

[Samishii23]

Try replacing jQuery() with $(), and report back. If that doesn't work I need to know what error the browser gives specifically.

[Alvaro Louzada]

i m jQuery instead of $ becuz there is alot of another jquery functions but i fixed: there is the code works on ie, firefox, chrome like a charm

function ShowDiv(Div_id){
	var div = Div_id;
	if(jQuery('#'+ div).is(':hidden')){

	jQuery('#'+ div).show(250);   
	}  
	else
	{   
	jQuery('#'+ div).hide(250);  
	}
	}