Problem with Error: Expected ')'...

[viki1967]

Hi all.

I have problem with this string javascript:

onclick="if(confirm('Confirm?')) location.href('form.asp?A=terry.d'arby'); return false;

The error javascript is:
Error: Expected ')'

Why? Can you help me?
Kind regards

[Dormilich]

Can you help me?

sure, your url string is invalid, you have alltogether 5 unescaped ' in your line (is that 2 and a half strings?), thus the last ) is part of a string.

[viki1967]

sure, your url string is invalid, you have alltogether 5 unescaped ' in your line (is that 2 and a half strings?), thus the last ) is part of a string.

When resolve my problem?
thanks

[Dormilich]

When resolve my problem?

as soon as you can.

you have four options (I know of)

• use the typographical apostrophe (U+2019)
• use encodeURI()
• nest the string (use " and ')
• escape the non-delimiter '

[viki1967]

thanks, but I try this and not working...

onclick="if(confirm('Confirm?')) location.href('Form.asp?A=' + encodeURIComponent(terry.d'arby) + '); return false;

[Dormilich]

well, you have 5 unescaped and 1 escaped ' (similar situation like before)

[viki1967]

well, you have 5 unescaped and 1 escaped ' (similar situation like before)

I don't understand.. sorry...

[Dormilich]

hm, not sure how the return string of encodeURICompon ent is treated.

encodeURICompon ent escapes all characters except the following: alphabetic, decimal digits, - _ . ! ~ * ' ( )

what about

onclick="if(confirm('Confirm?')) location.href('Form.asp?A=' + encodeURIComponent(terry.d'arby)[U] + '[/U]); return false;

[viki1967]

hm, not sure how the return string of encodeURICompon ent is treated.

Not working:

onclick="if(confirm('Confirm?')) location.href('Form.asp?A=' + encodeURI(terry.d'arby) + '); return false;

Not working:

onclick="if(confirm('Confirm?')) location.href('Form.asp?A=encodeURI(terry.d'arby)); return false;

[Dormilich]

think of what you wrote there.

onclick="if(confirm('Confirm?')) location.href('Form.asp?A=' + encodeURI(terry.d'arby)[U] + '[/U]); return false;

onclick="if(confirm('Confirm?')) location.href([U]'Form.asp?A=encodeURI(terry.d'[/U]arby)); return false;

[Dormilich]

something that just popped to my attention:

location.href = new_URI;
// not
location.href(new_URI);

at least that’s what’s defined in the specs

[viki1967]

Nothing...

onclick="if(confirm('Sure?')) location.href = 'Form.asp?A='+encodeURI(terry.d'arby)+''; return false;

[Dormilich]

any error messages?


—

[viki1967]

any error messages?

Error: Expected ')' :(

[Dormilich]

use one of the other two possibilities mentioned earlier.