Javascript issues with Mozilla

[danielji]

Hi, I'm having trouble with my javascript in Mozilla. I'm trying to use onClick within a link to call hidden divs in page. This seems to function properly in IE and Safari but not Mozilla. I would appreciate any feedback.


javascript in header:

[HTML]<script language="javas cript">
<!--

function changeLinks(lin k) {


if (link=="1") {

window.LinksInt ernal.style.dis play = '';
window.LinksExt ernal.style.dis play = 'none';
window.LinksQui ck.style.displa y = 'none';

}

if (link=="2") {

window.LinksInt ernal.style.dis play = 'none';
window.LinksExt ernal.style.dis play = '';
window.LinksQui ck.style.displa y = 'none';

}

if (link=="3") {

window.LinksInt ernal.style.dis play = 'none';
window.LinksExt ernal.style.dis play = 'none';
window.LinksQui ck.style.displa y = '';

}

</head>
[/HTML]
code in body:

[HTML]
<a onClick="change Links(3);return false;" style="cursor:h and"><img border="0" src="/images/quicklinks3.gif " class="right" ></a><a onClick="change Links(2);return false;" style="cursor:h and"><img border="0" class="right" src="/images/externallinks3. gif" ></a> <a onClick="change Links(1);return false;" style="cursor:h and"><img border="0" class="right" src="/images/internallinks3. gif" ></a><BR>[/HTML]

[gits]

hi ...

welcome to TSDN ...

try to use:

[CODE=javascript]window.LinksInt ernal.style.dis play = 'block';[/CODE]
instead of setting it to an empty string :)

kind regards

[Dasty]

And fix referencing too, because it is invalid. Make it this way:

document.getElementById('LinksInternal').style.display = '';

[gits]

And fix referencing too, because it is invalid. Make it this way:
[CODE=javascript]
document.getEle mentById('Links Internal').styl e.display = '';[/CODE]

yup ... of course ... and ensure you have the corresponding id set to the node ...

kind regards

[danielji]

Hi Friends, thank you for the prompt replies. I've tried both your recommendations and am still having trouble except this time it's not working in IE either.

[HTML]function changeLinks(lin k) {


if (link=="1") {

document.getEle mentByID('Links Internal').styl e.display = '';
document.getEle mentByID('Links External').styl e.display = 'none';
document.getEle mentByID('Links Quick').style.d isplay = 'none';

}

if (link=="2") {

document.getEle mentByID('Links Internal').styl e.display = 'none';
document.getEle mentByID('Links External').styl e.display = '';
document.getEle mentByID('Links Quick').style.d isplay = 'none';


}

if (link=="3") {

document.getEle mentByID('Links Internal').styl e.display = 'none';
document.getEle mentByID('Links External').styl e.display = 'none';
document.getEle mentByID('Links Quick').style.d isplay = '';


}


}
[/HTML]

called via onClick here:
[HTML]
<div id="LinksContai ner" >
<a onClick="change Links(3);return false;" style="cursor:h and"><img border="0" src="/images/quicklinks3.gif " class="right" ></a><a onClick="change Links(2);return false;" style="cursor:h and"><img border="0" class="right" src="/images/externallinks3. gif" ></a> <a onClick="change Links(1);return false;" style="cursor:h and"><img border="0" class="right" src="/images/internallinks3. gif" ></a><BR>

<% Call fn_getLinksExte rnal(2) %>
<% Call fn_getLinksInte rnal(2) %>
<% Call fn_getLinksQuic k(2) %>


</div>[/HTML]

[gits]

getElementById ... note that javascript is case-sensitive

kind regards

[danielji]

getElementById ... note that javascript is case-sensitive

kind regards

works now, many many thanks for catching that!

[gits]

no problem ... glad to hear you got it working :) ... post back to the forum anytime you have more questions

kind regards