Help with Firefox compatibility

**Lee** · Aug 5 '05, 04:55 PM

Re: Help with Firefox compatibility

Craig Keightley said:[color=blue]
>
>Please help, i have attached my page which worksin IE but i cannnot get the
>drop down menu to fucntion in firefox. Any one have any ideas why?[/color]

Just a suggestion:

Instead of asking us to look at over 700+ lines of code, build the
smallest example that shows your problem. There's a good chance
that you'll find the problem while you're doing that, and if not,
a lot more people will be willing to take a look.

**RobG** · Aug 6 '05, 01:25 AM

Re: Help with Firefox compatibility

Craig Keightley wrote:[color=blue]
> Please help, i have attached my page which worksin IE but i cannnot get the
> drop down menu to fucntion in firefox. Any one have any ideas why?
>[/color]
[...]

As already mentioned, no-one is going to help you with this because:

1. It's not reasonable to ask for debugging of hundreds of lines of
code that do not validate.

2. You give no indication of what the error is

3. Your code does not work at all - the lines are programmaticall y
broken and so generate tons of errors, most probably not related to
your issue.

4. There are two linked script files that may be the cause of the error.

So generate a small test case that replicates your problem and post
that. Below is a slab of your code that has been broken because of
the way you posted it - there are many other places where it happened.

Use 2 or 4 spaces for indents, not tabs, and manually break lines at
about 70 characters and ensure it will work if copy/pasted into a
local page.
[color=blue]
> height="34 " align="cen ter"></td></tr></table>'; //hdd
> var helpText4 = '<table cellpadding=0 cellspacing=0 ><tr><td
> class="ord er_text" valign="to p">Choos e which operating
> system you wish to use on your server, remember that some games will release
> servers / patches for windows much earlier that for Linux. It is advisable
> to choose the operating system that you are most comfortable with.</td><td
> class="ord er_text" width="105 " height="34 "
> align="cen ter"></td></tr></table>'; //os[/color]

[...]

Anyhow, here's a suggestion - in the following function:
[color=blue]
> function setCustomText(i temID,itemTxt){
> var custSetupTxt = document.getEle mentById("cust_ setup_text");
> var custSetupPrice = document.getEle mentById("cust_ setup_price");[/color]

Replace:
[color=blue]
> d=document.all;
> i = setCustomText.a rguments;
> d[i[0]].innerHTML = itemTxt;[/color]

With:

document.getEle mentById(itemID ).innerHTML = itemTxt;

[color=blue]
> custSetupTxt.in nerHTML = '<strong>Set Up</strong>'
> custSetupPrice. innerHTML = '£0'
> }[/color]

[...]
[color=blue]
>
> function setCustText(cus tDivName,custDi vPrice,itemName ,itemPrice){
> d=document.all;
> i = setCustText.arg uments;
> d[i[0]].innerHTML = itemName;
> d[i[1]].innerHTML = '£'+itemPrice;
> updateTotals()[/color]

Here again you've created local variables then ignored them:

function setCustText(cus tDivName,custDi vPrice,itemName ,itemPrice){
document.getEle mentById(custDi vName).innerHTM L = itemName;
document.getEle mentById(custDi vPrice).innerHT ML = '£'+itemPrice;
updateTotals()
}

[...]

**Craig Keightley** · Aug 17 '05, 10:05 AM

Re: Help with Firefox compatibility

hi all apologies for my last post
i have narrowed it down to the array part of the following function:

function showCPUs() {
var cpuItem = new Array();
//name brandID dualCore dualProcessor price cpuID
cpuItem[0] = ['Athlon 64 3000 (1.80
Ghz)','1','N',' N','0.00','a64. jpg','13'];
cpuItem[1] = ['Athlon 64 3200 (2.00
Ghz)','1','N',' N','5.00','a64. jpg','14'];
cpuItem[2] = ['Athlon 64 3500 (2.20
Ghz)','1','N',' N','15.00','a64 .jpg','15'];
cpuItem[3] = ['Athlon 64 4000 (2.40
Ghz)','1','N',' N','25.00','a64 .jpg','16'];
cpuItem[4] = ['Athlon 64 X2 4200 (2.20
Ghz)','1','Y',' N','35.00','a64 X2.jpg','17'];
cpuItem[5] = ['Athlon 64 X2 4400 (2.20
Ghz)','1','Y',' N','43.50','a64 X2.jpg','18'];
cpuItem[6] = ['Athlon 64 X2 4600 (2.40
Ghz)','1','Y',' N','51.50','a64 X2.jpg','19'];
cpuItem[7] = ['Athlon 64 X2 4800 (2.40
Ghz)','1','Y',' N','70.00','a64 X2.jpg','20'];
cpuItem[8] = ['Opteron 242 (1.60
Ghz)','1','N',' Y','20.00','opt eron.jpg','21'];
cpuItem[9] = ['Opteron 244 (1.80
Ghz)','1','N',' Y','39.50','opt eron.jpg','22'];
cpuItem[10] = ['Opteron 246 (2.00
Ghz)','1','N',' Y','42.00','opt eron.jpg','23'];
cpuItem[11] = ['Opteron 248 (2.20
Ghz)','1','N',' Y','50.50','opt eron.jpg','28'];
cpuItem[12] = ['Opteron 250 (2.40
Ghz)','1','N',' Y','100.00','op teron.jpg','0'];
cpuItem[13] = ['Opteron 252 (2.60
Ghz)','1','N',' Y','120.00','op teron.jpg','24'];
cpuItem[14] = ['Opteron 265 (1.80
Ghz)','1','Y',' Y','125.50','op teron.jpg','29'];
cpuItem[15] = ['Opteron 270 (2.00
Ghz)','1','Y',' Y','150.00','op teron.jpg','30'];
cpuItem[16] = ['Pentium 4 HT (2.80
Ghz)','2','N',' N','12.50','p4. jpg','26'];
cpuItem[17] = ['Pentium 4 HT (3.00
Ghz)','2','N',' N','12.50','p4. jpg','1'];
cpuItem[18] = ['Pentium 4 HT (3.20
Ghz)','2','N',' N','14.50','p4. jpg','2'];
cpuItem[19] = ['Pentium 4 HT (3.40
Ghz)','2','N',' N','16.50','p4. jpg','25'];
cpuItem[20] = ['Pentium D 820 (2.80
Ghz)','2','Y',' N','17.50','pd. jpg','3'];
cpuItem[21] = ['Pentium D 830 (3.00
Ghz)','2','Y',' N','24.00','pd. jpg','4'];
cpuItem[22] = ['Pentium D 840 (3.20
Ghz)','2','Y',' N','38.00','pd. jpg','5'];
cpuItem[23] = ['Xeon (2.40 Ghz)','2','N',' Y','20.00','xeo n.jpg','6'];
cpuItem[24] = ['Xeon (2.80 Ghz)','2','N',' Y','32.00','xeo n.jpg','7'];
cpuItem[25] = ['Xeon (3.00 Ghz)','2','N',' Y','40.00','xeo n.jpg','8'];
cpuItem[26] = ['Xeon (3.60 Ghz)','2','N',' Y','100.00','xe on.jpg','9'];
if (document.getEl ementById("cpuB rand").value == '') return;
if (document.getEl ementById("dual Core").value == '') return;
if (document.getEl ementById("dual Processor").val ue == '') return;
var item = "<strong>Pl ease select A CPU from below</strong>"
for (var i=1; i<cpuItem.lengt h; i++) {
if (document.getEl ementById("cpuB rand").value == cpuItem[i][1]) {
if (document.getEl ementById("dual Core").value == cpuItem[i][2])
{
if (document.getEl ementById("dual Processor").val ue ==
cpuItem[i][3]) {
if (item != "") item += "<br>";
item += '<input type="radio" name="selectedC PU"
value="'+cpuIte m[i][5]+'"
onClick="setCpu ('+cpuItem[i][4]+',\''+cpuItem[i][0]+'\')" >'+cpuItem[i][0];
//item += '<input type="radio" name="selectedC PU"
value="'+cpuIte m[i][5]+'"
onClick="setCus tText(\'cust_cp u_text\',\'cust _cpu_price\',\' <strong>CPU:</strong>
'+cpuItem[i][0]+'\',\''+cpuIte m[i][4]+'\');setCpu('+ cpuItem[i][4]+',\''+cpuItem[i][0]+'\')"[color=blue]
>'+cpuItem[i][0];[/color]
}
}
}
}
document.getEle mentById("cpuNa me").innerHTM L = item;
//document.getEle mentById("cpuNa me").innerHTM L = 'test';
}is this correct?

**Lee** · Aug 17 '05, 05:05 PM

Re: Help with Firefox compatibility

Craig Keightley said:[color=blue]
>
>hi all apologies for my last post[/color]

Better, but could still use work.
Don't post tab characters, convert to spaces and don't indent much.
Many news systems wrap lines, which makes it hard to read and even
harder to test.

It helps a lot if you post testable code. At the very least, you
should include the form fields that your code references, so we
can see that there's no problem it the way that you access values.
Some browsers don't support a "value" attribute of Select controls,
for example (although Firefox does, so that's not your problem).

Here's a simplified version of your code. I removed some tests
that aren't necessary ("item" can never be empty, for example),
and moved the array initialization to outside of the function so
it only gets executed once, and I simplified the initialization.
I also combined a chain of "if" statements into one.

This version works in IE and Firefox:

<html>
<head>
<title>demo</title>
<script type="text/javascript">
var cpuItem = [
['Athlon 64 3000 (1.80 Ghz)','1','N',' N','0.00','a64. jpg','13'],
['Athlon 64 3200 (2.00 Ghz)','1','N',' N','5.00','a64. jpg','14'],
['Athlon 64 X2 4200 (2.20 Ghz)','1','Y',' N','35.00','a64 X2.jpg','17'],
['Athlon 64 X2 4400 (2.20 Ghz)','1','Y',' N','43.50','a64 X2.jpg','18'],
['Opteron 242 (1.60 Ghz)','1','N',' Y','20.00','opt eron.jpg','21'],
['Opteron 244 (1.80 Ghz)','1','N',' Y','39.50','opt eron.jpg','22'],
['Opteron 250 (2.40 Ghz)','1','N',' Y','100.00','op teron.jpg','0'],
['Opteron 252 (2.60 Ghz)','1','N',' Y','120.00','op teron.jpg','24'],
['Opteron 265 (1.80 Ghz)','1','Y',' Y','125.50','op teron.jpg','29'],
['Opteron 270 (2.00 Ghz)','1','Y',' Y','150.00','op teron.jpg','30'],
['Pentium 4 HT (2.80 Ghz)','2','N',' N','12.50','p4. jpg','26'],
['Pentium 4 HT (3.00 Ghz)','2','N',' N','12.50','p4. jpg','1'],
['Pentium D 820 (2.80 Ghz)','2','Y',' N','17.50','pd. jpg','3']
];

function showCPUs(f) {
var item = "<strong>Pl ease select A CPU from below</strong>"
for (var i=1; i<cpuItem.lengt h; i++) {
if (f.cpuBrand.val ue == cpuItem[i][1]
&& f.dualCore.valu e == cpuItem[i][2]
&& f.dualProcessor .value == cpuItem[i][3]) {
item += '<br><input type="radio" name="selectedC PU" value="'
+cpuItem[i][5]+'"onClick="set Cpu('
+cpuItem[i][4]+',\''+cpuItem[i][0]+'\')" >'
+cpuItem[i][0];
}
}
document.getEle mentById("cpuNa me").innerHTM L = item;
}
</script>
</head>
<body>
<form>
<select name="cpuBrand" >
<option value="1" selected>1</option>
<option value="2">2</option>
</select>
<select name="dualCore" >
<option value="Y" selected>Y</option>
<option value="N">N</option>
</select>
<select name="dualProce ssor">
<option value="Y" selected>Y</option>
<option value="N">N</option>
</select>
<input type="button" onclick="showCP Us(this.form)" value="showCPUs ">
</form>
<div id="cpuName"
style="border-style:solid;pad ding:1em;width: 20em">cpuName</div>
</body>
</html>

**Dr John Stockton** · Aug 18 '05, 05:35 PM

Re: Help with Firefox compatibility

JRS: In article <4303092d$0$137 04$cc9e4d1f@new s-text.dial.pipex .com>,
dated Wed, 17 Aug 2005 10:58:59, seen in news:comp.lang. javascript,
Craig Keightley <dont@spam.me > posted :
[color=blue]
> cpuItem[23] = ['Xeon (2.40 Ghz)','2','N',' Y','20.00','xeo n.jpg', '6'];[/color]

N.B. Ghz != GHz .

--
© John Stockton, Surrey, UK. *@merlyn.demon. co.uk / ??.Stockton@phy sics.org ©
Web <URL:http://www.merlyn.demo n.co.uk/> - FAQish topics, acronyms, & links.
Correct <= 4-line sig. separator as above, a line precisely "-- " (SoRFC1036)
Do not Mail News to me. Before a reply, quote with ">" or "> " (SoRFC1036)

Help with Firefox compatibility

Help with Firefox compatibility

Comment

Comment

Comment

Comment

Comment