What is lacking to have the greatest common denominator of two given numbers?

[cess]

Hi!!! i would like to know if what is lacking in the codes below to have a greatest common denominator of two given(by the user) numbers?? I'm confused and i need your help!



import java.io.*;
public class gcd {
public static void main (String args[])throws Exception
{

String number;
int numberInteger1, numberInteger2;
int i=0;
{
System.out.prin t ("Enter first number:");
InputStreamRead er no= new InputStreamRead er(System.in);
BufferedReader num=new BufferedReader( no);
number=num.read Line();
numberInteger1= Integer.parseIn t(number);

System.out.prin t ("Enter second number:");
InputStreamRead er n= new InputStreamRead er(System.in);
BufferedReader nu=new BufferedReader( no);
number=num.read Line();
numberInteger2= Integer.parseIn t(number);


while ((i%numberInteg er1==0) || (i%numberIntege r2==0)) {

System.out.prin tln ("Greatest Common Denominator:" +i);
i = i + 1;

}

}

}
}

[horace1]

Hi!!! i would like to know if what is lacking in the codes below to have a greatest common denominator of two given(by the user) numbers?? I'm confused and i need your help!

you logic was not quite correct, try

import java.io.*;
public class gcd {
public static void main (String args[])throws Exception
{

String number;
int numberInteger1,numberInteger2;
int i=1;  // ** start at 1
{
System.out.print ("Enter first number:");
InputStreamReader no= new InputStreamReader(System.in);
BufferedReader num=new BufferedReader(no);
number=num.readLine();
numberInteger1=Integer.parseInt(number);

System.out.print ("Enter second number:");
InputStreamReader n= new InputStreamReader(System.in);
BufferedReader nu=new BufferedReader(no);
number=num.readLine();
numberInteger2=Integer.parseInt(number);


while ((i<numberInteger1) && (i<numberInteger2)) {
  if((numberInteger1%i==0) && (numberInteger2%i==0))
     System.out.println ("Greatest Common Denominator:" +i);
i = i + 1;

}

}

}
}

[cess]

tnx..for the reply, but it did not work (below)...

 import java.io.*; 
public class gcd {
public static void main (String args[])throws Exception
{
 
String number;
int numberInteger1,numberInteger2;
int i=1; // ** start at 1
{
System.out.print ("Enter first number:");
InputStreamReader no= new InputStreamReader(System.in);
BufferedReader num=new BufferedReader(no);
number=num.readLine();
numberInteger1=Integer.parseInt(number);
 
System.out.print ("Enter second number:");
InputStreamReader n= new InputStreamReader(System.in);
BufferedReader nu=new BufferedReader(no);
number=num.readLine();
numberInteger2=Integer.parseInt(number);
 
 
while ((i<numberInteger1) && (i<numberInteger2)) {
if((numberInteger1%i==0) && (numberInteger2%i==0))
System.out.println ("Greatest Common Denominator:" +i);
i = i + 1;
 
}
 
}
 
}
}

[dmjpro]

try this code .....

 int gcd(int num1,int num2) 
{
int mod;
while((mode = num2%num1) != 0)
{
num2 = num1;
num1 = mod;
}
return num1;
}

plz send me ur reply.....
i am online

[r035198x]

tnx..for the reply, but it did not work (below)...

import java.io.*;
public class gcd {
public static void main (String args[])throws Exception
{

String number;
int numberInteger1, numberInteger2;
int i=1; // ** start at 1
{
System.out.prin t ("Enter first number:");
InputStreamRead er no= new InputStreamRead er(System.in);
BufferedReader num=new BufferedReader( no);
number=num.read Line();
numberInteger1= Integer.parseIn t(number);

System.out.prin t ("Enter second number:");
InputStreamRead er n= new InputStreamRead er(System.in);
BufferedReader nu=new BufferedReader( no);
number=num.read Line();
numberInteger2= Integer.parseIn t(number);


while ((i<numberInteg er1) && (i<numberIntege r2)) {
if((numberInteg er1%i==0) && (numberInteger2 %i==0))
System.out.prin tln ("Greatest Common Denominator:" +i);
i = i + 1;

}

}

}
}

Always give the error message or output vs expected output so that others know where to help you with.

And guys please let's all make sure we are using code tags everytime when posting code.

[dmjpro]

sorry .....


next time expected things will be posted

[r035198x]

sorry .....


next time expected things will be posted

Just added them for you.

P.S Congrats on passing the 100 post mark.

[cess]

sorry .....


next time expected things will be posted

tnx for the support!! i got it!!!

import java.io.*;
 public class gcd {
  public static void main (String args[])throws Exception
  {
  	
   String number;
   int numberInteger1,numberInteger2;
   int i=1;
    {
   System.out.print ("Enter first number:");
   InputStreamReader no= new InputStreamReader(System.in);
   BufferedReader num=new BufferedReader(no);
   number=num.readLine();
   numberInteger1=Integer.parseInt(number);
   
   System.out.print ("Enter second number:");
   InputStreamReader n= new InputStreamReader(System.in);
   BufferedReader nu=new BufferedReader(no);
   number=num.readLine();
   numberInteger2=Integer.parseInt(number);
       
              while ((i%numberInteger1!=0) || (i%numberInteger2!=0)) {
              i= i+1;
                
            } 
                System.out.println ("Greatest Common Denominator:"+i);      
     }
                  
   }
}