Use onClick to change CF values

[ndeeley]

Yes, sorry i posted the wrong code.

The actual hyperlinking is this:

<td style="width: 100px;"><a href="http://marlin/engeastl/scripts/RepairWorkshops/Devaction_search2.cfm?WorkshopWONO='#WorkshopWONO#'">#WorkshopWONO#</a></td>

and the processing code is:

<cfquery datasource="repairmdb" name="GetClientNo">
	select 		ID, 
			WorkshopFK, 
			ClientFK,
			SiteFK,
			WORecdate,
			ResponseLevelFK,
			ClientWONO,
			WorkshopWONO,
			WorkshopJOBNO,
		 DateRecordAdded
	from		tblWorkshops
	where		WorkshopWONO = '#WorkshopWONO#'

WorkshopWONO is a string (tho actually a number stored in a text field, for reasons that they don't all have a WONO).

The processing page appears, but tells me that no record is found, so it's not processing the received value properly.

[acoder]

You don't need the single quotes around WorkshopWONO, so the link should be:

Devaction_search2.cfm?WorkshopWONO=#WorkshopWONO#

Note that you could still store it as a number and use NULL for non-values.

[ndeeley]

That's grand - thanks acoder!

Neil

[acoder]

Though it's probably not as much of a problem with an internal application (except with an programming-savvy disgruntled employee), a point to bear in mind is that you should sanitise inputs before using them in queries (e.g. use cfqueryparam), otherwise you could be subject to an SQL injection attack.

[ndeeley]

Ok...for the non technically minded (ie given a book on CF and dumped in the deep end) what is an SQL injection attack?

[acoder]

This article should help, though maybe one or two things may not apply to Coldfusion 5. For a general link on SQL injection, see the Wikipedia entry.

[ndeeley]

Interesing, and not about a cure for Swine Flu like I first thought...

I'm cleaning up my code so I shall apply all the instructions within!

Cheers acoder!
Neil