remove memory leak from this function strcpy

[ammarSyed]

node_pointer *structures = new node_pointer;
 char buf[] = "dsdsdsdsdsds\0";
 structures->common_fields = buf;


  strcpy(structures>common_fields,"aaaaasfd\0");
  cout<<structures->common_fields;

Syed Muhammad Ammar: memory leak error at strcpy function.....

[zmbd]

You need to provide more of your code.
Best guess is that you've initialized the node and then don't release the allocation and then create a new node and then repeat this act over and over.
Remember it is always good practice to ensure that all allocations are released when they are no-longer needed and whenever a fatal error occurs.

[weaknessforcats]

You create a new node_pointer each time. That's OK.
But:

char buf[] = "dsdsdsdsdsds\0";
structures->common_fields = buf;

every one of your node_pointer gets the same address. namely, the address of buf. So each node copies to the same address.

Unfortunately, when the function completes, buf is deleted (it's a local variable) and now all of your nodes are skrogged.

Never use the address of a local variable in such a way that the address exists after the function completes and the variable it points at is gone.

[ammarSyed]

memory leak warning strcpy

Warning 1 warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_ WARNINGS. See online help for details. D:\Visual Studio WebApplications \test memory leak 1\test memory leak 1\test memory leak 1.cpp


how to remove this warning........ .

[divideby0]

the complier wants you to use strcpy_s instead of strcpy because of potential security issues, I think. you can disable the warning using something like below.

#pragma warning(disable : 4996)

#include <stdio.h>
#include <string.h>
... // other includes and code bits

[Rabbit]

Your threads have been merged. Please do not post your questions more than once.

[ani627]

Try strncpy or memcpy.