Link error.

[Roonie]

so i signed up this morning and posted an introduction. i mentioned an error that was and then was no longer . . . thus it ceased to be a problem . . .

but i guess i spoke too soon.

anyways, i have not been programming for a while (six years) and this is the first time i am using a container class . . . i wrote a very simple program to test out the vector container:

main.cpp:
----------------------------------------------------------------------------

#include <cstdlib>
#include <iostream>
#include <vector>

#include "fish.cpp"

using namespace std;

int main(int argc, char *argv[])
{
    typedef std::vector<Fish> t_FishVect;
    t_FishVect school(10);
    
    for(int i = 0; i < 10; i++)
    {
            school[i].setFace(i);
    }
    
    for(int i = 0; i < 10; i++)
    {
            cout << school[i].getFace();
    }
    
    cout << "\n";
    system("PAUSE");
    return EXIT_SUCCESS;
}

----------------------------------------------------------------------------

fish.cpp:
----------------------------------------------------------------------------

class Fish
{
      public:
             Fish() {face = 0;}
             Fish(int fishFace) {face = fishFace;}
             ~Fish();
             
             void setFace(int newFace) {face = newFace;}
             int getFace() {return face;}
      
      private:
              int face;
};

----------------------------------------------------------------------------

everything compiles, but the linker exits with errors:

[Linker error] undefined reference to 'Fish::~Fish()' (x3)

now when i create a container of pointers to Fish it works. but as i understand it, the whole point of containers is to get away from pointers and other such nasties, so i consider a container of pointers to be a failure at an attempt to ease the use of pointers.

as i said, ive never used a container before and im a bit rusty on c++ in general (having not used it for 6 years) so if im missing something simple, please let me know . . . earlier i cut out, saved and then pasted back the exact same portion of code (the Fish class declaration) and it worked. ill try that again, but id rather find a solution that didnt involve my linker being in a good or bad mood.

maybe i just need a different one. i would rather not do that though . . . im using the dev-cpp ide which uses gcc and i like open source.

any help would be greatly appreciated.

[horace1]

in Fish you declare the destructor

             ~Fish();

but don't define it (give it any code enclosed in {}), try

             ~Fish() {};

[Roonie]

trying . . .

. . . same errors. i dunno. i think ill use a different compiler just to see . . .

(also, thx for the code tags . . . didnt see that on first glance . . .)

[arne]

trying . . .

. . . same errors. i dunno. i think ill use a different compiler just to see . . .

(also, thx for the code tags . . . didnt see that on first glance . . .)

Compiles fine for me with horace1's correction.
Without it, I see the undefined reference errors you mentioned.

[Roonie]

what compiler are you using arne?

also, when i changed the Fish function declarations to the more appropriate style for larger functions (with prototypes and then Fish::_____'s) . . . i got additional link errors complaining that each function was defined more than once.

im beginning to think that i just need a different compiler.

[horace1]

I have compiled and run your code with the GNU g++ compiler and Borland CBuilder without problems (after I fixed the destructor). A run gives
0123456789
Press any key to continue . . .

post your updated code?

[Roonie]

that is exactly what im trying to get . . .

main.cpp is the same.

fish.cpp:

class Fish
{
      public:
             Fish();
             Fish(int fishFace);
             ~Fish() {};
             
             void setFace(int newFace);
             int getFace();
      
      private:
              int face;
};

Fish::Fish()
{
     face = 0;
}

Fish::Fish(int fishNum)
{
     face = fishNum;
}

void Fish::setFace(int newFace)
{
     face = newFace;
}

int Fish::getFace()
{
     return face;
}

[arne]

what compiler are you using arne?

I am using gcc 4.0.2.

[arne]

A run gives
0123456789

Equivalent result for me:
0123456789
sh: PAUSE: command not found

[horace1]

that is exactly what im trying to get . . .

main.cpp is the same.

fish.cpp:

class Fish
{
      public:
             Fish();
             Fish(int fishFace);
             ~Fish() {};
             
             void setFace(int newFace);
             int getFace();
      
      private:
              int face;
};

Fish::Fish()
{
     face = 0;
}

Fish::Fish(int fishNum)
{
     face = fishNum;
}

void Fish::setFace(int newFace)
{
     face = newFace;
}

int Fish::getFace()
{
     return face;
}

this compiles and runs with the original main() OK using g++

[Roonie]

alright . . . i cant seem to figure this out with the time i have right now. (my drunkie sister is going camping tonight and needs me to make a run for her).

thanks for the help guys . . . i guess my plan at the moment is to take a breather for a while and then try just straight up the newest release of gcc.

and if that fails, ill try a different container class.

thanks again.