what is better? straightforward question on variable declaration

Collapse
This topic is closed.
X
X
 
  • Time
  • Show
Clear All
new posts
  • Vasileios Zografos

    #1

    what is better? straightforward question on variable declaration

    Ok, easy question.
    Not caring about the variable scope what is better (i.e. possibly in
    memory allocation etc)


    int someVar=0;

    for (int i=0;i<1000;i++)
    {
    ...
    someVar++;
    ...
    }


    OR

    for (int i=0;i<1000;i++)
    {
    ...
    int someVar=0;
    someVar++;
    ...
    }




    Or it really doesnt make any difference at all?

  • Victor Bazarov

    #2
    Re: what is better? straightforward question on variable declaration

    "Vasileios Zografos" <vzografos@bcs. org.uk> wrote...[color=blue]
    > Ok, easy question.
    > Not caring about the variable scope what is better (i.e. possibly in
    > memory allocation etc)
    >
    >
    > int someVar=0;
    >
    > for (int i=0;i<1000;i++)
    > {
    > ...
    > someVar++;
    > ...
    > }
    >
    >
    > OR
    >
    > for (int i=0;i<1000;i++)
    > {
    > ...
    > int someVar=0;
    > someVar++;
    > ...
    > }
    >
    >
    >
    >
    > Or it really doesnt make any difference at all?[/color]

    For the POD like your 'int someVar' it most likely does not
    matter.

    Victor


    Comment

    • Jack Klein

      #3
      Re: what is better? straightforward question on variable declaration

      On Tue, 01 Jul 2003 22:25:42 +0100, Vasileios Zografos
      <vzografos@bcs. org.uk> wrote in comp.lang.c++:
      [color=blue]
      > Ok, easy question.
      > Not caring about the variable scope what is better (i.e. possibly in
      > memory allocation etc)[/color]

      Have you read what you posted carefully? Does it really represent the
      question you wanted to ask?
      [color=blue]
      > int someVar=0;
      >
      > for (int i=0;i<1000;i++)
      > {
      > ...
      > someVar++;
      > ...
      > }[/color]

      In the example above, someVar will take on the values of 1 through
      1000 on successive iterations of the loop.
      [color=blue]
      > OR
      >
      > for (int i=0;i<1000;i++)
      > {
      > ...
      > int someVar=0;
      > someVar++;
      > ...
      > }[/color]

      In the example above, someVar will always be 0 at the point where it
      is defined and initialized, and always 1 after the post increment
      expression. It will never take on the values 2 through 1000, no
      matter how many times the loop executed.
      [color=blue]
      > Or it really doesnt make any difference at all?[/color]

      If this were real code, it certainly would make a difference.

      In principle, a variable defined inside a block is created when
      execution reaches the line that defines it, and is destroyed when
      control reaches the end of the block or leaves the block.

      If a variable defined inside a loop is a type with a non-trivial
      constructor and destructor, each of these will be called for each
      iteration of the loop. If the object is a primitive built-in type,
      and perhaps even a POD structure or class type, the compiler may
      generate code to allocate the memory once and reuse it each time, or
      it may decide to allocate and deallocate the memory by some method in
      each iteration of the loop. There is no requirement or guarantee
      either way.

      --
      Jack Klein
      Home: http://JK-Technology.Com
      FAQs for
      comp.lang.c http://www.eskimo.com/~scs/C-faq/top.html
      comp.lang.c++ http://www.parashift.com/c++-faq-lite/
      alt.comp.lang.l earn.c-c++ ftp://snurse-l.org/pub/acllc-c++/faq

      Comment

      • Vasileios Zografos

        #4
        Re: what is better? straightforward question on variable declaration

        > Have you read what you posted carefully? Does it really represent the[color=blue]
        > question you wanted to ask?[/color]

        Yes[color=blue]
        >
        >[color=green]
        >>int someVar=0;
        >>
        >>for (int i=0;i<1000;i++)
        >>{
        >> ...
        >> someVar++;
        >> ...
        >>}[/color]
        >
        >
        > In the example above, someVar will take on the values of 1 through
        > 1000 on successive iterations of the loop.
        >
        >[color=green]
        >>OR
        >>
        >>for (int i=0;i<1000;i++)
        >>{
        >> ...
        >> int someVar=0;
        >> someVar++;
        >> ...
        >>}[/color]
        >
        >
        > In the example above, someVar will always be 0 at the point where it
        > is defined and initialized, and always 1 after the post increment
        > expression. It will never take on the values 2 through 1000, no
        > matter how many times the loop executed.[/color]

        yeah....I am not interested in the value of someVar. More on if it has
        some overhead on the construction/desctruction, memory and so on.
        [color=blue]
        > If this were real code, it certainly would make a difference.
        >
        > In principle, a variable defined inside a block is created when
        > execution reaches the line that defines it, and is destroyed when
        > control reaches the end of the block or leaves the block.
        >
        > If a variable defined inside a loop is a type with a non-trivial
        > constructor and destructor, each of these will be called for each
        > iteration of the loop. If the object is a primitive built-in type,
        > and perhaps even a POD structure or class type, the compiler may
        > generate code to allocate the memory once and reuse it each time, or
        > it may decide to allocate and deallocate the memory by some method in
        > each iteration of the loop. There is no requirement or guarantee
        > either way.
        >[/color]

        Comment

        • Vasileios Zografos

          #5
          Re: what is better? straightforward question on variable declaration

          > For the POD like your 'int someVar' it most likely does not[color=blue]
          > matter.
          >
          > Victor
          >
          >[/color]
          so, if instead int someVar it was something like

          vector<int> someVar

          ???

          Comment

          • Vasileios Zografos

            #6
            Re: what is better? straightforward question on variable declaration

            [color=blue]
            > Non-trivial constructor will be invoked during execution of
            > every loop cycle.
            >
            > I am not sure of the reason for your question, but if you are
            > concerned with performance,[/color]

            it was about performace really (or anyting else that I am missing)

            don't be until your code works.[color=blue]
            > If the design of your algorithm calls for the existence of
            > the object beyond the loop, then declare it before, otherwise
            > declare it inside. Only if later, once your algorithm is
            > working fine, you discover that it's unacceptably sluggish
            > due to multitude of calls to the constructor, you could try
            > to get rid of them. But at the beginning try following this
            > simple rule: do not declare an object until you actually need
            > it.[/color]

            ok I ll follow that rule
            Thanks
            Vasileios

            Comment

            Working...