external struct declaration

Collapse
This topic is closed.
X
X
 
  • Time
  • Show
Clear All
new posts
  • anonymous

    #1

    external struct declaration

    I have a Lex file containing definitions of 2 structures like:

    %{
    struct a {...};
    struct b
    {
    struct a i;
    ...
    };
    struct a x[10];
    struct b y[10];
    ....
    %}

    In main program I have external declarations

    /* main.c */

    extern struct a;
    extern struct b;
    extern struct a x[];
    extern struct b y[];

    When I try to compile and run I am getting

    'Warning:Useles s keyword or type name in external declaration'
    and
    'Invalid use of undefined type : struct a'

    Is there anything wrong in the external declarations
    of the structure?
  • Jens.Toerring@physik.fu-berlin.de

    #2
    Re: external struct declaration

    anonymous <iunknown2k4@ya hoo.co.in> wrote:[color=blue]
    > I have a Lex file containing definitions of 2 structures like:[/color]
    [color=blue]
    > %{[/color]

    [Hint for those not used to lex: the '%{' starts a section of
    C code which goes unchanged into the C source file created from
    the lex file, so the question isn't really OT.]
    [color=blue]
    > struct a {...};[/color]

    This makes a new structure type 'a' known within that (lex) file
    (but only within that file, nowhere else).
    [color=blue]
    > struct b
    > {
    > struct a i;
    > ...
    > };[/color]

    And that of the new structure type 'b'.
    [color=blue]
    > struct a x[10];
    > struct b y[10];[/color]

    And here you define two arrays of structures of type 'a' and 'b'.
    Everything fine so far.
    [color=blue]
    > In main program I have external declarations[/color]
    [color=blue]
    > /* main.c */[/color]
    [color=blue]
    > extern struct a;[/color]

    You can use 'extern' only when there's a variable or function name
    following it. What you write here is basically like having a line like

    extern int;

    which simply makes doesn't make sense. That explains the first warning
    [color=blue]
    > 'Warning:Useles s keyword or type name in external declaration'[/color]

    Even worse, when the compiler reads that file it has no idea at all
    what 'struct a' is or means. It doesn't know that 'struct a' has been
    (or may only will be) declared in a different source file. What you
    need to do is either declare again here what 'struct a' means - but
    that's a rather bad idea, because it's too easy to have the decla-
    rations get out of sync - or to create an include file, into which
    you put what 'struct a' is, and then include it from every file that
    needs to know what 'struct a' means. If you do that the second warning
    [color=blue]
    > 'Invalid use of undefined type : struct a'[/color]

    for the line
    [color=blue]
    > extern struct a x[];[/color]

    will disappear.
    Regards, Jens
    --
    \ Jens Thoms Toerring ___ Jens.Toerring@p hysik.fu-berlin.de
    \______________ ____________ http://www.toerring.de

    Comment

    • anonymous

      #3
      Re: external struct declaration

      [...][color=blue]
      > Even worse, when the compiler reads that file it has no idea at all
      > what 'struct a' is or means. It doesn't know that 'struct a' has been
      > (or may only will be) declared in a different source file.[/color]
      [...]

      But when I create the executable, both the .o files are used:

      gcc -o lex.yy.o main.o

      so, the definitions must be visible - right?

      Comment

      • Jens.Toerring@physik.fu-berlin.de

        #4
        Re: external struct declaration

        anonymous <iunknown2k4@ya hoo.co.in> wrote:[color=blue]
        > [...][color=green]
        >> Even worse, when the compiler reads that file it has no idea at all
        >> what 'struct a' is or means. It doesn't know that 'struct a' has been
        >> (or may only will be) declared in a different source file.[/color]
        > [...][/color]
        [color=blue]
        > But when I create the executable, both the .o files are used:[/color]
        [color=blue]
        > gcc -o lex.yy.o main.o[/color]
        [color=blue]
        > so, the definitions must be visible - right?[/color]

        But then you're already linking. But what you got was an error
        message from the compiler. And the compiler only deals with
        single files at a time (if you don't count included files, but
        they simple are more or less pasted in the source). So, when
        the compiler sees your yy.c file (or however it's called) it
        finds the definition of the structure and creates an .o file from
        it without problems. But when it gets to main.c (the one where you
        also use the structure), it has forgotten everything it did see in
        the other file (typically, it's a completely new invocation of the
        compiler) and so it has no idea what that structure is supposed to
        be and complains, and you don't even get a main.o file. The easiest
        way to make the type "struct a" visible to both files is to put the
        definition into an additional include file that then gets included
        from both files.
        Regards, Jens
        --
        \ Jens Thoms Toerring ___ Jens.Toerring@p hysik.fu-berlin.de
        \______________ ____________ http://www.toerring.de

        Comment

        • Michael Wojcik

          #5
          Re: external struct declaration


          In article <2govdbF54dilU1 @uni-berlin.de>, Jens.Toerring@p hysik.fu-berlin.de writes:[color=blue]
          > anonymous <iunknown2k4@ya hoo.co.in> wrote:[color=green]
          > > /* main.c */
          > > extern struct a;[/color]
          >
          > You can use 'extern' only when there's a variable or function name
          > following it. What you write here is basically like having a line like
          >
          > extern int;
          >
          > which simply makes doesn't make sense. That explains the first warning
          >[color=green]
          > > 'Warning:Useles s keyword or type name in external declaration'[/color][/color]

          Good so far.
          [color=blue]
          > Even worse, when the compiler reads that file it has no idea at all
          > what 'struct a' is or means.[/color]

          Incomplete struct declarations are fine in C, provided you don't try
          to use them as complete types, and in fact they're useful for
          declaring opaque types in at least one context - function prototypes.

          If main.c doesn't need to complete structs a and b (if it doesn't
          need to do anything with their members, and doesn't need to take
          their size, eg using the sizeof operator), then:

          struct a;
          struct b;

          would be fine in main.c, to introduce the names "a" and "b" to the
          struct namespace.

          The only use I can think of offhand for this "bare" struct tag
          declaration is before a function prototype which uses a pointer to
          the struct, as in

          struct a;
          extern void foo(struct a *);

          because there a previously-unseen struct tag (if you omitted the
          "struct a;" line) will declare the structure only in prototype scope,
          which is basically useless.
          [color=blue]
          > It doesn't know that 'struct a' has been
          > (or may only will be) declared in a different source file.[/color]

          Which is fine, since it doesn't need to know whether any other TU
          ("source file") has declared struct a. That's irrelevant to the
          behavior of main.c.

          In this case, the OP probably wants to use struct a as a complete
          type - if main.c is going to operate on that that array of struct a,
          it needs to be complete - but there are APIs that use incomplete
          structure definitions to create and pass opaque types safely.

          --
          Michael Wojcik michael.wojcik@ microfocus.com

          Advertising Copy in a Second Language Dept.:
          Tapestry of the encounting and the farewell, the birth and the death.
          You can hear the human being's song running through the 100 years.
          -- Squaresoft

          Comment

          • Peter Shaggy Haywood

            #6
            Re: external struct declaration

            Groovy hepcat Jens.Toerring@p hysik.fu-berlin.de was jivin' on 16 May
            2004 10:51:23 GMT in comp.lang.c.
            Re: external struct declaration's a cool scene! Dig it!
            [color=blue]
            >anonymous <iunknown2k4@ya hoo.co.in> wrote:
            >[color=green]
            >> extern struct a;[/color]
            >
            >You can use 'extern' only when there's a variable or function name
            >following it. What you write here is basically like having a line like
            >
            >extern int;
            >
            >which simply makes doesn't make sense. That explains the first warning[/color]

            Actually, as the compiler (probably) sees it, the errant line
            declares an external object of type struct. Hence this warning:
            [color=blue][color=green]
            >> 'Warning:Useles s keyword or type name in external declaration'[/color][/color]

            "struct" (without a tag) is indeed a useless keyword or type name.

            --

            Dig the even newer still, yet more improved, sig!


            "Ain't I'm a dog?" - Ronny Self, Ain't I'm a Dog, written by G. Sherry & W. Walker.
            I know it's not "technicall y correct" English; but since when was rock & roll "technicall y correct"?

            Comment

            Working...