Why am I getting this error in my SQL string?

[Alex Dransfield]

I get the error that there is "no value given for one or more required parameters" when I attempt to execute this command:

string commandString = "SELECT moduletitle, unit FROM [EXAMDAT] WHERE moduletitle ='" + modules.SelectedItem.ToString() + "';";

The string looks correct to me, why isn't it working?

[Stewart Ross]

I suspect that the field names you have listed as

[moduletitle, unit]

should be

[moduletitle], [unit]

or more simply

moduletitle, unit

-Stewart

[Alex Dransfield]

Ah sorry, I changed that. I'm still getting the error though and I'm not sure why.

Here's my full method

private bool checkSame(string mod, string unit)
        {
            string commandString = "SELECT moduletitle, unit FROM EXAMDAT WHERE moduletitle ='" + modules.SelectedItem.ToString() + "';";
            try
            {
                OleDbCommand command = new OleDbCommand(commandString, connection);
                OleDbDataReader reader = command.ExecuteReader();
                while (reader.Read())
                {
                    if ((reader["moduletitle"] == modules.SelectedItem.ToString()) && (reader["unit"] == units.SelectedItem.ToString()))
                    {
                        return true;
                    }
                    else
                        return false;
                }
            }
            catch (Exception e)
            {
                string exception = "Error in retreiving the data" + e;
                MessageBox.Show(exception);
                return false;
            }

            return false;
        }

[johny10151981]

print the query,
then copy the query
and then run from your database editing window
which ever software you are using... and see what went wrong

few more things where is your mysql server? if it is in linux server make sure table name you typed it exists. Cause in linux its case sensitive

[Plater]

Which statement is throwing the error?
What kind of database are you connecting to with the Ole namespace?

It is possible maybe that the [] are being interpreted not as literals but as markers for a parameter and it is complaining that you have not filled in the parameter? [ ] aren't needed around tablenames/columnnames that do not have spaces in them