dynamically loop through tiers in picturebox control

**GaryTexmo** · Jun 10 '10, 08:13 PM

Hey, as a fellow WoW player I say to heck with the haters! :P Glad to see you're still working on this, actually.

I'm not sure what you mean here though. Why do you need a loop? When you click a certain talent, couldn't you just do the checks there and enable/disable other talents based on that event? Some quick pseudo...

Code:

public void TalentClick(object sender, TalentClickEventArgs e)
{
  Talent t = sender as Talent;
  if (t != null)
  {
    t.Spent.Increment(e.Increment);

    foreach (Talent tChild in t.ChildTalents)
    {
      tChild.Enabled = (t.Spent == t.MaximumPoints);
    }
  }
}

Would something like that work?

**Samishii23** · Jun 10 '10, 08:36 PM

Well basicly what little theory is actually coming to me is this.

Theres 44 Talents in the tree. So every 4 talents is 1 tier.
Current Tier = (Total Points / 5) + 1

On Change:
- Check Points
- Cycle through current tier and next to see if next tier can be enabled or disabled, based current amount of points.
- enable and disable as needed.

I have the offical code for the website version. But honestly, not sure how to push that to exactly what I'm doing. lol

This is Javascript btw, and i'm adding comments to the areas I understand...

Code:

function checkEnabled(treeNum) {
	calcTreePts(); // Updates the counters for use...
	
	var tree = talentTrees[treeNum]; // gets the tree object
	for(var talentNum = 0, len = tree.talents.length; talentNum < len; ++talentNum) { // cycle through each talent

		var talent = tree.talents[talentNum]; // current talent object
		var enabled = (talent.tier == 0 || tree.pts >= (talent.tier * talentVars.pointsPerTier)); // if first tier is true or current points is more or same as points needed for next tier

		if(enabled && talent.pts == 0 && (talentVars.pts >= talentVars.maxPts || pageMode != "calc")) // if enabled and cur talent has 0 points and (im guessing current total points accross whole calc) is more then allowed total points
			enabled = false;
			
		// (original comment) Dependent talents have special cases
		if(enabled && !checkDependentTalent(talent))
			enabled = false;

		if(enabled) {
			enableTalent(talent);
			enableArrows(talent);

		} else {
			disableTalent(talent);
			disableArrows(talent);
		}
	}
}

I'm sorry. This looks simple, but when I try to put the loop together in my head before in the editor, I go blank. I don't know why. =\

**GaryTexmo** · Jun 10 '10, 09:04 PM

Ah, I misunderstood what you meant by dependency. I was thinking of just the arrows :)

I don't really know web development much, but that loop looks like it updates the whole tree when a point is changed, is that correct?

That loop does seem pretty straight forward... enable a talent if it's tier is less than the total number of points in the tree divided by the points per tier.

Are you not sure how to convert this to C#?

**Samishii23** · Jun 10 '10, 09:24 PM

Kinda. The biggest problem is that I want to add checks for if theres only, say for example 10 points. Check up to 3 tiers. I believe thats where I'm starting to over think it and why I'm going blank. lol

I mean pulling 44 loops when clicking on the talent quickly, would probably end up badly.

**GaryTexmo** · Jun 10 '10, 11:11 PM

Well, yes and no... that's not terribly many as far as a computer is concerned, and if you're not doing a lot of work you're probably ok. As for stopping when you have no more talents, just put a break in there when the count is greater than the total number of spent talents.

You don't have to constrain yourself to how they did it though... like I said, this looks like a full refresh. Could you simply update when you click on a specific talent? That's kinda what I was getting at in that pseudo code I posted above.

* Talent was clicked
* Update the talent itself
* Enable/disable any talents above or below as necessary

It could work if your talent array supported it...

Code:

List<Talent>[] talents = new List<Talent>[MAX_TIERS]();

?

I'm not trying to tell you to rewrite your code or anything, just throwing out ideas :D

**Samishii23** · Jun 11 '10, 01:20 AM

Originally posted by GaryTexmo

Well, yes and no... that's not terribly many as far as a computer is concerned, and if you're not doing a lot of work you're probably ok. As for stopping when you have no more talents, just put a break in there when the count is greater than the total number of spent talents.

You don't have to constrain yourself to how they did it though... like I said, this looks like a full refresh. Could you simply update when you click on a specific talent? That's kinda what I was getting at in that pseudo code I posted above.

* Talent was clicked
* Update the talent itself
* Enable/disable any talents above or below as necessary

It could work if your talent array supported it...

Code:

List<Talent>[] talents = new List<Talent>[MAX_TIERS]();

?

I'm not trying to tell you to rewrite your code or anything, just throwing out ideas :D

Yea right now, I have the Individual talent counters working. Its enabling the next tier for the counting that is what I'm getting stuck on. I'm pushing some code on the side for it. I'll probably get it posted tomorrow. Have family things to tend to. :P

**Samishii23** · Jun 16 '10, 08:43 PM

This is what I came up with. It seems to work. But there is a noticable amount of lag cycling through the whole tree each click.

Code:

public void HandleChange_TreeCount(object X, EventArgs EX) {
  ToolStripStatusLabel Obj = X as ToolStripStatusLabel;
  
  if (Obj == null)
    return;

  int id = s2i(Obj.Name.Substring(4, 1)), // Example Name "Tree1Counter"
      CurPts = s2i(Obj.Text), // .Text property holds the total tree count
      CurTier = (CurPts / 5) + 1, // This defines what Tier the current amount of points would suggest
      TreeStart = (id - 1) * 44, // ID: 0 thru 2, want starting numbers like this: 0, 44, 88
      TreeEnd = (TreeStart + 43);

  if (CurTier == 1) // Do nothing if its the 1st tier
    return;

  for (int x = TreeStart; x < TreeEnd; x++) {
    bool Enable = false;

    // First Tier and Figures out next tier
    if (TD.Tier[x] == 0 && CurPts >= (TD.Tier[x] * 5))
      Enable = true;

    if (Enable)
      Talent_Enable(x);
    else
      Talent_Disable(x);
    }
  }

Now I just need to think about say, stop the loop if maybe it's already enabled, or if just on the 2nd tier in terms of points, just cycle through to the next tier only cut out the extra cpu usage.

**Samishii23** · Jun 16 '10, 09:18 PM

Oooook... Apparently I already implemented the Next tier thing without realizing it... Ugh. Sorry to have created a, now, useless thread... lol
The above code has been scrapped... heh

**GaryTexmo** · Jun 16 '10, 09:37 PM

lol :D

Glad you got it figured out!

**Samishii23** · Jun 16 '10, 10:08 PM

Apparently I already covered all the points I needed to in my Add Point method, since it already covered all the Talents anyways, it was fine without me knowing it.

Now the only thing I have to do is, basicly do the same thing but now figure out not "Enabling" the next tier. Its the doing an image swap. Which I had already put into use, but it doesn't seem to work.

Woo. lol. Thanks for the support Gary

dynamically loop through tiers in picturebox control

dynamically loop through tiers in picturebox control

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment