Desperate help needed on tables in .php

**Marcin Dobrucki** · May 29 '06, 09:55 AM

Re: Desperate help needed on tables in .php

Ladysniper@gmai l.com wrote:[color=blue]
> DESPERATE doesn't begin to describe it.
>
> Can someone PLEASE tell me what is WRONG with this code?[/color]

Without even going into the php, IMHO you need to tidy up the HTML
that the code generates:

<a href="/directory.htm"> Member
Directory</a>  &n bsp; &nbsp ;


5 non breaking spaces in a shade of red? Surely, there is better
ways to space things. I'd also suggest using some basic CSS for the
table layouts instead of trying to give all cells own parameters.

Lastly, try some html table generators. Yours is broken, eg:

<tr height='20'><td valign'top'>AZ</td></tr> 

<tr height='20'><td valign'top'>85259</td></tr> 

At least '=' is missing here.

/Marcin

**Geoff Berrow** · May 29 '06, 10:15 AM

Re: Desperate help needed on tables in .php

Message-ID: <1148875699.928 003.240630@i40g 2000cwc.googleg roups.com> from
Ladysniper@gmai l.com contained the following:
[color=blue]
>Warning...lo ng coding....[/color]

Gulp! That is one messy bit of code. Deprecated code, nested tables,
no CSS. Ugh!

Your database queries (which I'm sure can be optimised) are outputting
something like this

print(" <tr height='20'><td valign='top'>".$row Name[0]."</td></tr> \n");

For starters, that's a single column. It will never line up with a multi
column header

Frankly I wouldn't even try to start fixing this. It needs to be
rewritten from scratch.

--
Geoff Berrow (put thecat out to email)
It's only Usenet, no one dies.
My opinions, not the committee's, mine.
Simple RFDs http://www.ckdog.co.uk/rfdmaker/

**Erwin Moller** · May 29 '06, 10:25 AM

Re: Desperate help needed on tables in .php

Ladysniper@gmai l.com wrote:
[color=blue]
> DESPERATE doesn't begin to describe it.
>
> Can someone PLEASE tell me what is WRONG with this code?
>
> Now..a bit of background. It is a search results page for
> http://www.azsoma.info/directory.htm. (use Scottsdale for the city)
>
> If you go look, you see that the search results post (I do have my
> table borders up for debugging) but it doesn't line up with the table
> above it...the whole scroll background doesn't show up and I cannot get
> my results to have a space between them. And on top of it...they want
> an inline frame! I haven't even attempted that...at all....
>
> Please...can someone help me. Hell, I'll pay someone if I have to...be
> glad to...but this page needs to be done for the client....
>
> Warning...long coding....
>
> Thank you in advance....plea se, if someone could/would help me....[/color]

<snipped code>

Hi,

Please try to be nice to this group.
Instead of expecting from the readers to wrestle through many many unrelated
lines of (broken) HTML, you might consider to strip it down to your
coreproblem, and post that.

A possible healthy side effect: When you strip the code down the problem,
you often see what is wrong yourself because you are not subtracted by
noise.)

Of course, if you are lucky a friendly soul will answer you anyway.
Your chances to get an answer are just better if you keep your question to
the point.

Regards,
Erwin Moller

**David Haynes** · May 29 '06, 10:55 AM

Re: Desperate help needed on tables in .php

Ladysniper@gmai l.com wrote:[color=blue]
> DESPERATE doesn't begin to describe it.
>
> Can someone PLEASE tell me what is WRONG with this code?
>
> Now..a bit of background. It is a search results page for
> http://www.azsoma.info/directory.htm. (use Scottsdale for the city)
>
> If you go look, you see that the search results post (I do have my
> table borders up for debugging) but it doesn't line up with the table
> above it...the whole scroll background doesn't show up and I cannot get
> my results to have a space between them. And on top of it...they want
> an inline frame! I haven't even attempted that...at all....
>
> Please...can someone help me. Hell, I'll pay someone if I have to...be
> glad to...but this page needs to be done for the client....
>
> Warning...long coding....
>
> Thank you in advance....plea se, if someone could/would help me....[/color]

Wow! a lot of things could be improved on this page.

1. Use a stylesheet.

2. Dump the boxed comments especially when they state the obvious. (i.e.
Now, if there are any records, we'll set through getting the xxx.)

3. Since the only difference in a bunch of these is the xxx value, make
it a function.

function showInTable($su b_fld_name) {
$sql = "select sub_fld_value "
."from pf_submissions "
."where sub_rec_id = '{$row['sub_rec_id']' "
."and sub_fld_name = '$sub_fld_name' ";

$result = mysql_query($sq l);
while( $row = @mysql_fetch_ro w($result) {
?>
<tr height="20">
<td valign="top">
 // stylesheets would be better here

<?php echo $row[0];?>


</td>
</tr>
<?php
}
$mysql_free_res ult($result);
}

This reduces your inner loop to something like:
foreach( array('Full Name', 'Office Address', 'Office City', ...) as
$field_name ) {
showInTable($fi eld_name);
}

4. Remove the silly 1=1 test use a boolean flag to know whether this is
the first entry (i.e. the where)

5. You don't close your <form>

6. Since both your outer table and inner table have width 800, I don't
understand what you want the outer table to do.

7. $variable1 is never set

8. The at the end of each table row will not cause double spacing.
Either set double spacing up in the style sheet (preferred) or alter the
showInTable function to emit an empty row (<tr><td>  </td></tr>)
after each populated row.

That's probably enough to get you started.

-david-

**Ladysniper@gmail.com** · May 29 '06, 12:45 PM

Re: Desperate help needed on tables in .php

Okay, I want to thank everyone who answered me. For the record, I
didn't actually write the .php code for that search results page. I'm
just trying to get the .html part to work, with the .php. The guy who
wrote it... I told him the tables didn't line up right..he said it was
in the .html code...and I've been looking for DAYS now! I felt it was
in the .php code...somewher e....

Question...how do I embed the .php in a style sheet? See, I'm totally
new at this. Though I'm learning (and I've taken the above pointers in
hand! Thanks!) I still don't quite know enough to take what he wrote
and make it work. (sighs)..

Okay, I'll try to work from here and see what I can do with it..and
I'll try to clean up that code some! I found it annoying to work with
also, but not knowing that much about .php, I didn't know if I could
take the comments out, nor can I find where the error is to just post
the problem.... etc....

Thanks! You guys are awesome!!

**Kimmo Laine** · May 29 '06, 12:55 PM

Re: Desperate help needed on tables in .php

<Ladysniper@gma il.com> wrote in message
news:1148906348 .769964.314370@ u72g2000cwu.goo glegroups.com.. .
[color=blue]
> Question...how do I embed the .php in a style sheet? See, I'm totally
> new at this. Though I'm learning (and I've taken the above pointers in
> hand! Thanks!) I still don't quite know enough to take what he wrote
> and make it work. (sighs)..[/color]

It works just the opposite. You embed the stylesheet into the php, not vice
versa. :)
place the following tag into your php sourcecode somewhere in the
<head></head> section: <link rel="stylesheet " type="text/css"
href="mystyle.c ss" /> and write the css-rules into <mystyle.css> . There are
a few other ways to embed a stylesheet (style-tag, import) but that's the
basic case.

--
"ohjelmoija on organismi joka muuttaa kofeiinia koodiksi" -lpk
spam@outolempi. net | Gedoon-S @ IRCnet | rot13(xvzzb@bhg byrzcv.arg)

**william.clarke@gmail.com** · May 30 '06, 10:15 PM

Re: Desperate help needed on tables in .php

Here a link you may find very useful for learning CSS:

W3Schools.com

http://www.w3schools.com/css/default.asp

W3Schools offers free online tutorials, references and exercises in all the major languages of the web. Covering popular subjects like HTML, CSS, JavaScript, Python, SQL, Java, and many, many more.

Desperate help needed on tables in .php

Desperate help needed on tables in .php

Comment

Comment

Comment

Comment

Comment

Comment

Comment