print "...."; Question

Collapse
This topic is closed.
X
X
Collapse
 
  • Page of 1
  • Time
  • Show
Clear All
new posts
Previous template Next
  • Steff
    #1

    print "...."; Question

    I am wandering if my code is making sense... I use a lot the print function.
    Is it weird in this case where I have to display an array ? I thought it
    would be better to have the entire array in php but now I am not sure if
    that makes sense. Can you tell me please ?


    <html>

    <head>

    <link href="../withStyle.css" rel="stylesheet " type="text/css">

    <title>Reportin g System Demand Management</title>
    </head>

    <body>


    <center><h1>A dd request</h1></p></center>
    <hr>

    <p align="center">
    &nbsp;

    <?php

    print "<form ACTION='..' method='POST'>" ;
    print "<table border='1' width='45%'>";
    print "<tr>";
    print "<td align='left' width='50%' height='25'>";
    print "<p align='left'>Re quest Name</p>";
    print "</td>";
    print "<td align='left' width='50%' height='25' colspan='2'>
    <p align='left'><i nput type='text' size='40'
    name='request_n ame'><img src='requis.gif ' width='15' height='15'></p>";
    print "</td>";
    print "</tr>";
    print "<tr>";
    print "<td align='left' width='50%' height='25'>";
    print "<p align='left'>Re quest Date</p>";
    print "</td>";
    print "<td align='left' width='50%' height='25' colspan='2'>";
    print "<p align='left'>";
    print "<select name='day'>";
    print "<option selected>dd</option>";
    print "<option>01 </option>";
    print "<option>02 </option>";
    print "<option>03 </option>";
    print "<option>04 </option>";
    print "<option>05 </option>";
    print "<option>06 </option>";
    print "<option>07 </option>";
    print "<option>08 </option>";
    print "<option>09 </option>";
    print "<option>10 </option>";
    print "<option>11 </option>";
    print "<option>12 </option>";
    print "<option>13 </option>";
    print "<option>14 </option>";
    print "<option>15 </option>";
    print "<option>16 </option>";
    print "<option>17 </option>";
    print "<option>18 </option>";
    print "<option>19 </option>";
    print "<option>20 </option>";
    print "<option>21 </option>";
    print "<option>22 </option>";
    print "<option>23 </option>";
    print "<option>24 </option>";
    print "<option>25 </option>";
    print "<option>26 </option>";
    print "<option>27 </option>";
    print "<option>28 </option>";
    print "<option>29 </option>";
    print "<option>30 </option>";
    print "<option>31 </option>";
    print "</select>";
    print "<select name='month'>";
    print "<option selected>mm</option>";
    print "<option>01 </option>";
    print "<option>02 </option>";
    print "<option>03 </option>";
    print "<option>04 </option>";
    print "<option>05 </option>";
    print "<option>06 </option>";
    print "<option>07 </option>";
    print "<option>08 </option>";
    print "<option>09 </option>";
    print "<option>10 </option>";
    print "<option>11 </option>";
    print "<option>12 </option>";
    print "</select>";
    print "<select name='year'>";
    print "<option selected>aaaa</option>";
    print "<option>20 06</option>";
    print "<option>20 07</option>";
    print "<option>20 08</option>";
    print "<option>20 09</option>";
    print "<option>20 10</option>";
    print "<option>20 11</option>";
    print "<option>20 12</option>";
    print "<option>20 13</option>";
    print "<option>20 14</option>";
    print "<option>20 15</option>";
    print "<option>20 16</option>";
    print "<option>20 17</option>";
    print "<option>20 18</option>";
    print "<option>20 19</option>";
    print "<option>20 20</option>";
    print "</select><img src='requis.gif ' width='15' height='15'>";
    print "</p>";
    print "</td>";
    print "</tr>";
    print "<tr>";
    print "<td align='left' width='50%' height='25'>";
    print "<p align='left'>Cl ient Name</p>";
    print "</td>";
    print "<td align='left' width='50%' height='25' colspan='2'>";
    print "<p align='left'>";
    print "<select name='Client_na me' size='1'>";
    print "<option>Na me</option>";

    //connexion
    $c1=oci_connect ("stephane","St ef1975",$bdtest 05);

    $query="select client_firstnam e||' '||client_lastn ame as client_fullname
    from clients";

    $stmt=oci_parse ($c1,$query);

    oci_execute($st mt);

    while ($row = oci_fetch_array ($stmt,OCI_NUM) )
    {
    print "<option>";
    echo $row[0];
    print "</option>";
    }

    oci_free_statem ent($stmt);



    print "</select><img src='requis.gif ' width='15' height='15'></p>";
    print "</td>";
    print "</tr>";
    print "<tr>";
    print "<td align='left' width='50%' height='25'>";
    print "<p align='left'>Re quest Type</p>";
    print "</td>";
    print "<td align='left' width='50%' height='25' colspan='2'>";
    print "<p align='left'>";
    print "<select name='Request Type' size='1'>";
    print "<option>Reques t Type</option>";

    $query="select request_type_na me from request_types";

    $stmt=oci_parse ($c1,$query);

    oci_execute($st mt);

    while ($row = oci_fetch_array ($stmt,OCI_NUM) )
    {
    print "<option>";
    echo $row[0];
    print "</option>";
    }

    oci_free_statem ent($stmt);


    print "</select><img src='requis.gif ' width='15' height='15'>";
    print "</p>";
    print "</td>";
    print "</tr>";
    print "<tr>";
    print "<td align='left' width='50%' height='25'>";
    print "<p align='left'>Cl ient Departement</p>";
    print "</td>";
    print "<td align='left' width='50%' height='25' colspan='2'>";
    print "<p align='left'>";
    print "<select name='Departmen t' size='1'>";
    print "<option>Depart ement</option>";

    $query="select department_name from departments";

    $stmt=oci_parse ($c1,$query);

    oci_execute($st mt);

    while ($row = oci_fetch_array ($stmt,OCI_NUM) )
    {
    print "<option>";
    echo $row[0];
    print "</option>";
    }

    oci_free_statem ent($stmt);

    print "</select>";
    print "</p>";
    print "</td>";
    print "</tr>";
    print "<tr>";
    print "<td align='left' width='50%' height='25'>";
    print "<p align='left'>Ex pected Delivery Date</p>";
    print "</td>";
    print "<td align='left' width='50%' height='25' colspan='2'>";
    print "<p align='left'>";
    print "<select name='day'>";
    print "<option selected>dd</option>";
    print "<option>01 </option>";
    print "<option>02 </option>";
    print "<option>03 </option>";
    print "<option>04 </option>";
    print "<option>05 </option>";
    print "<option>06 </option>";
    print "<option>07 </option>";
    print "<option>08 </option>";
    print "<option>09 </option>";
    print "<option>10 </option>";
    print "<option>11 </option>";
    print "<option>12 </option>";
    print "<option>13 </option>";
    print "<option>14 </option>";
    print "<option>15 </option>";
    print "<option>16 </option>";
    print "<option>17 </option>";
    print "<option>18 </option>";
    print "<option>19 </option>";
    print "<option>20 </option>";
    print "<option>21 </option>";
    print "<option>22 </option>";
    print "<option>23 </option>";
    print "<option>24 </option>";
    print "<option>25 </option>";
    print "<option>26 </option>";
    print "<option>27 </option>";
    print "<option>28 </option>";
    print "<option>29 </option>";
    print "<option>30 </option>";
    print "<option>31 </option>";
    print"</select>";
    print "<select name='month'>";
    print "<option selected>mm</option>";
    print "<option>01 </option>";
    print "<option>02 </option>";
    print "<option>03 </option>";
    print "<option>04 </option>";
    print "<option>05 </option>";
    print "<option>06 </option>";
    print "<option>07 </option>";
    print "<option>08 </option>";
    print "<option>09 </option>";
    print "<option>10 </option>";
    print "<option>11 </option>";
    print "<option>12 </option>";
    print "</select>";
    print "<select name='year'>";
    print "<option selected>aaaa</option>";
    print "<option>20 06</option>";
    print "<option>20 07</option>";
    print "<option>20 08</option>";
    print "<option>20 09</option>";
    print "<option>20 10</option>";
    print "<option>20 11</option>";
    print "<option>20 12</option>";
    print "<option>20 13</option>";
    print "<option>20 14</option>";
    print "<option>20 15</option>";
    print "<option>20 16</option>";
    print "<option>20 17</option>";
    print "<option>20 18</option>";
    print "<option>20 19</option>";
    print "<option>20 20</option>";
    print "</select>";
    print "</p>";
    print "</td>";
    print "</tr>";
    print "<tr>";
    print "<td align='left' width='50%' height='25'>";
    print "<p align='left'>Co mment on Request</p>";
    print "</td>";
    print "<td align='left' width='50%' height='25' colspan='2'><te xtarea
    name=comment cols=30 rows=2></textarea><p>";
    print "</td>";
    print "</tr>";
    print "<tr>";
    print "<td align='left' width='50%' height='25'>";
    print "<p align='left'></td>";
    print "<td align='left' width='25%' height='25'>";
    print "<p align='left'><i nput type='submit' name='addButton '
    value='Add Request'>";
    print "</p>";
    print "</td>";
    print "<td align='left' width='25%' height='25'>";
    print "<input type='reset' name='resetButt on' value='Reset'>" ;
    print "</td>";
    print "</tr>";
    print "</table>";
    print "</form>";

    //close connexion
    oci_close($c1);

    ?>

    <p align="left"></p>
    <hr>


    <p align="center"> <a href="index.htm ">[Home]</a></p>


    </body>

    </html>

    // thanks for looking!


    Tags: None
    • Jerry Stuckle
      #2
      Re: print &quot;....&quot ;; Question

      Steff wrote:[color=blue]
      > I am wandering if my code is making sense... I use a lot the print function.
      > Is it weird in this case where I have to display an array ? I thought it
      > would be better to have the entire array in php but now I am not sure if
      > that makes sense. Can you tell me please ?
      >
      >[/color]
      <code snipped>[color=blue]
      >
      > // thanks for looking!
      >
      >[/color]


      It's all a matter of style. Personally, I don't use print for straight
      HTML - I just code the HTML and go into PHP when I need it. Exceptions
      are things like quick elements.

      A quick look at your code (and I might have missed something) and it
      looks like nothing before the connexion line requires PHP. So why even
      have PHP there? Just code it as HTML.

      Your while loop fetching the rows I would have similar, except I'd code
      it as:

      while ($row = oci_fetch_array ($stmt,OCI_NUM) )
      {
      echo "<option>" . $row[0] . "</option>";
      }

      You don't need two print statements and an echo here.

      Again, you have a bunch of print statements following this which are
      just displaying HTML code - no PHP variables, etc. So why even
      complicate things by using PHP? Just do the straight HTML code.

      And so on.

      The bottom line is - my first order of business is coding clarity. When
      you have a lot of just HTML code, it complicates matters to put them in
      print or echo statements. It takes longer to process as PHP than it
      does to just output the straight html. So why do it?



      --
      =============== ===
      Remove the "x" from my email address
      Jerry Stuckle
      JDS Computer Training Corp.
      jstucklex@attgl obal.net
      =============== ===

        Comment

        Previous template Next
        Working...