Problems with formatting and editing a php script

**Paul 'piz' Wellner Bou** · Jul 17 '05, 03:27 AM

Re: Problems with formatting and editing a php script

> Formatting Issues[color=blue]
>
> 1) Why do I get the extra '(' before the '(delete) link
> 2) Why does the 4th (and I think it is always the last rather than being
> just the 4th) record always show below the Add Record link?
>
>
> Editing Problem
>
> 1) When I actually select to delete a record it doesn't, I think it is
> related to an 'id' issue but can't see where
> 2) When I click a link to edit it, it doesn't populate the form below...Why?
>
> I know I am asking a lot. Thanks for any help indeed. If you are asking me
> to put any code in to test please help me by being specific
>
> Cheers
>
> Paul[/color]

Hi Paul,

Don't know if anyone else, but I'm too lazy to read all your code and
to search the relevant lines. Could you please post only the relevant
code lines here?
thx.

Greetz
Paul.

**Dan Weeb** · Jul 17 '05, 03:27 AM

Re: Problems with formatting and editing a php script

"Paul 'piz' Wellner Bou" <paul.wellner@u nited-scripts.com> wrote in message
news:c0vmnf$1c6 17p$2@ID-205474.news.uni-berlin.de...[color=blue][color=green]
> > Formatting Issues
> >
> > 1) Why do I get the extra '(' before the '(delete) link
> > 2) Why does the 4th (and I think it is always the last rather than being
> > just the 4th) record always show below the Add Record link?
> >
> >
> > Editing Problem
> >
> > 1) When I actually select to delete a record it doesn't, I think it is
> > related to an 'id' issue but can't see where
> > 2) When I click a link to edit it, it doesn't populate the form[/color][/color]
below...Why?[color=blue][color=green]
> >
> > I know I am asking a lot. Thanks for any help indeed. If you are asking[/color][/color]
me[color=blue][color=green]
> > to put any code in to test please help me by being specific
> >
> > Cheers
> >
> > Paul[/color]
>
> Hi Paul,
>
> Don't know if anyone else, but I'm too lazy to read all your code and
> to search the relevant lines. Could you please post only the relevant
> code lines here?
> thx.
>[/color]
H Paul,

I will try but as i said I really have no idea where it is going wrong so I
thought I would try and give as much as poss.

if ($submit) {
// here if no ID then adding else we're editing
if ($id) {
$sql = "UPDATE research_main SET
date_event='$da te_event',info_ research='$info _research',medi um_name='$mediu m
_name',place_na me='$place_name ',date_invest=' $date_invest',v erified_event=' $
verified_event' ,closed_event=' $closed_event' WHERE id=$id";
} else {
$sql = "INSERT INTO research_main
(date_event,inf o_research,medi um_name,place_n ame,date_invest ,verified_event ,
closed_event) VALUES
('$date_event', '$info_research ','$medium_name ','$place_name' ,'$date_invest' ,
'$verified_even t','$closed_eve nt')";
}
// run SQL against the DB
$result = mysql_query($sq l);
echo "Record updated/edited!<p>";
} elseif ($delete) {
// delete a record
$sql = "DELETE FROM research_main WHERE id=$id";
$result = mysql_query($sq l);
echo "$sql Record deleted!<p>";
} else {
// this part happens if we don't press submit
if (!$id) {
// print the list if there is not editing

$result = mysql_query("SE LECT * FROM research_main", $db);
while ($myrow = mysql_fetch_arr ay($result)) {

echo "<table border=2>\n";
echo "<tr><td> Investigation Date </td><td> Research Information
</tr><td> Mediums Name </tr><td> Location </tr><td> date being
Researched </tr>\n";

printf("(<a href=\"%s?id=%s \"><tr><td>% s</td><td> %s
</td><td>%s</td></tr></a> \n", $PHP_SELF, $myrow["id"],
$myrow["date_event "], $myrow["info_resea rch"], $myrow["medium_nam e"],
$myrow["place_name "], $myrow["date_inves t"], $myrow["verified_event "],
$myrow["closed_eve nt"]);

printf("<a href=\"%s?id=%s &delete=yes\">( DELETE)</a><br>", $PHP_SELF,
$myrow["id"]);

}

}

?>

</p>
</div>
<p> </p>
<P>

<a href="<?php echo $PHP_SELF?>">AD D A RECORD</a>

<P>

<form method="post" action="<?php echo $PHP_SELF?>">

<?php

if ($id) {

// editing so select a record

$sql = "SELECT * FROM research_main WHERE id=$id";

$result = mysql_query($sq l);

$myrow = mysql_fetch_arr ay($result);

$id = $myrow["id"];

$date_event = $myrow["date_event "];

$info_research = $myrow["info_resea rch"];

$medium_name = $myrow["medium_nam e"];

$place_name = $myrow["place_name "];

$date_invest = $myrow["date_inves t"];

$verified_event = $myrow["verified_event "];

$closed_event = $myrow["closed_eve nt"];

// print the id for editing

?>

<p>
<input type=hidden name="id" value="<?php echo $id ?>">

<?php

}

?>

**Cameron** · Jul 17 '05, 03:27 AM

Re: Problems with formatting and editing a php script

Dan Weeb wrote:[color=blue]
> Hi All,
>
> I have struggled through this far with help from many of you so thanks. I am
> stuck again. I am really new to this so don't be harsh :-)
>
> There are a few problems. You can run the script here
> http://www.pbrown.com/research/test1.php to see the formatting issues
>
> Formatting Issues
>
> 1) Why do I get the extra '(' before the '(delete) link
> 2) Why does the 4th (and I think it is always the last rather than being
> just the 4th) record always show below the Add Record link?
>
>
> Editing Problem
>
> 1) When I actually select to delete a record it doesn't, I think it is
> related to an 'id' issue but can't see where
> 2) When I click a link to edit it, it doesn't populate the form below...Why?
>
> I know I am asking a lot. Thanks for any help indeed. If you are asking me
> to put any code in to test please help me by being specific
>
> Cheers
>
> Paul
>[/color]

I also don't have time to trudge through all the code, however I did
have a quick look and I saw

printf("(<a href=\"%s?id=%s \"><tr><td>% s</td><td> %s
</td><td>%s</td></tr></a> \n", $PHP_SELF, $myrow["id"],
$myrow["date_event "], $myrow["info_resea rch"], $myrow["medium_nam e"],
$myrow["place_name "], $myrow["date_inves t"], $myrow["verified_event "],
$myrow["closed_eve nt"]);

Note the printf("(<a href=\.... on the first line, could this be your
extra (?

~Cameron

**Geoff Berrow** · Jul 17 '05, 03:27 AM

Re: Problems with formatting and editing a php script

I noticed that Message-ID: <c0vkp3$sal$1$8 300dec7@news.de mon.co.uk> from
Dan Weeb contained the following:
[color=blue]
>Hi All,
>
>I have struggled through this far with help from many of you so thanks. I am
>stuck again. I am really new to this so don't be harsh :-)
>
>There are a few problems. You can run the script here
>http://www.pbrown.com/research/test1.php to see the formatting issues
>
>Formatting Issues
>
>1) Why do I get the extra '(' before the '(delete) link[/color]
You have an extra bracket in the printf
[color=blue]
>2) Why does the 4th (and I think it is always the last rather than being
>just the 4th) record always show below the Add Record link?
>
>[/color]

Try organising your code better, then you can see where the errors are.
There are missing tags. I'd do it like this (BTW I recognise the
tutorial...:-)

There are lots of mistakes with both formatting and dispaying your data.
Forinstance in your prinf() you had $myrow["verified_event "],
$myrow["closed_eve nt"]with no place in your table to put them.

I assume you only need the header row once and that you did intend to
put a </table> tag in somewhere.

Try this for the while() loop (untested)

echo "<table border=2>\n";
echo "<tr>
<td> Investigation Date </td>
<td> Research Information </tr>
<td> Mediums Name </tr>
<td> Location </tr>
<td> date being Researched </td>
<td> Delete </tr>
</tr>\n";

while ($myrow = mysql_fetch_arr ay($result)) {
printf("<tr>
<td><a href=\"%s?id=%s \">%s</a></td>
<td> %s </td>
<td>%s</td>
<td>%s</td>
<td>%s</td>
<td><a href=\"%s?id=%s &delete=yes\">( DELETE)</a>"</td>
</tr> \n",
$PHP_SELF,$myro w["id"],$myrow["date_inves t"],$myrow["info_resea rch"],
$myrow["medium_nam e"],$myrow["place_name "],
$myrow["date_event "],$PHP_SELF,$myr ow["id"]);
}
echo "</table>";
[color=blue]
>Editing Problem
>
>1) When I actually select to delete a record it doesn't, I think it is
>related to an 'id' issue but can't see where[/color]

You should have a field in that database called 'id' it should be the
primary key and should be set as INT and be auto_increment.

Have you? Because the query is not returning a result for this field.

Try doing this instead.
// delete a record
$sql = "DELETE FROM research_main WHERE id=$id";
if(mysql_query( $sql)){
echo "$sql Record deleted!";}
else{ echo "Could not delete record";}

This is a very bad way of deleting records by the way. If this page is
indexed by search engines it will delete all your records. However,
let's get it working first eh?

[color=blue]
>2) When I click a link to edit it, it doesn't populate the form below...Why?[/color]

Missing id so it can't find the record. You need to fix that first then
we'll look at that.
--
Geoff Berrow (put thecat out to email)
It's only Usenet, no one dies.
My opinions, not the committee's, mine.
Simple RFDs http://www.ckdog.co.uk/rfdmaker/

Problems with formatting and editing a php script

Problems with formatting and editing a php script

Comment

Comment

Comment

Comment