Output Array to a new file

[ryokubaka]

I have a function that will read a file of numbers and place them into an array. I need to create a new function that will, given that stored array, output the array to a new file.

This is the code I have:

int Save(char *File, long *Array, int Size) {
  FILE *fp = fopen(File, "wb");
  if (fp == NULL) { // check to see if file opens; if NULL, failed
    printf("Error opening file. \n");
    return 0;
  }

  if (fwrite(&Array, sizeof(int), 1, fp) != Size) {
    printf("File write error.");
  }

  fclose(fp);
  return (Size);
}

Right now, it does not work. The fwrite function is suppose to return the number of copies (= Size, determined in other function -- that does work), but it is not copying all of the values. I'm unsure of how to do it.

[Banfa]

But you have passed 1 as the number of records to write (effectively the array size for your code) to fwrite.

[ryokubaka]

Haha, wow, you are right. I didn't even see that. After changing that line to

   if (fwrite(&Array, sizeof(int), Size, fp) != Size) {

It now runs properly. However, when I check the output file, this is what is written:

^B^Z\210^B^WFÿ3 ^C¼%ÿ?Hôoutputt

I believe it's because in my fwrite line, I am using &Array rather than the value -- however, I don't know how I can retrieve the values from Array and print them.

[Banfa]

Well you probably should use Array rather than &Array but that wont make much difference.

You see that data because you are writing binary data to the file, the contents of the integers, so the data in the file is binary and non-readable.

If you want the file to be readable then use fprintf instead of fwrite.

[ryokubaka]

That ended up working. I changed the fwrite to

  for (count = 0; count < Size; count++) {
    fprintf(fp, "%ld\n", Array[count]);
  }

and now it saves it perfectly. Thank you!