Help, am getting this error C2784 message

[zelmila19]

Hi am working on this program that will display the sum, difference, product and quotient of two numbers using the selection structures. This is what I did:


#include <iostream>

using std::cout;
using std::cin;
using std::endl;

int num1 = 0;
int num2 = 0;
int answer = 0;
char operation;

int main()
{
cout << "Enter first number: ";
cin >> num1;
cout >> "Enter 1 (add) or 2 (subtract) or 3 (multiply) or 4 (divide): ";
cin >> operation;
cout << "Enter second number: ";
cin >> num2;

if (operation == 1)
{
answer = num1 + num2;
cout << "Sum: " << answer << endl;
}
else
if (operation == 2)
{
answer = num1 - num2;
cout << "Difference : " << answer << endl;
}
else
if (operation == 3)
{
answer = num1 * num2;
cout << "Product: " << answer << endl;
}
else
if (operation == 4)
{
answer = num1 / num2;
cout << "Quotient: " << answer << enl;
} //end if

system ("pause");
return 0;
} //end of main function
but am getting this errors:

error C2784: 'std::basic_ist ream<char,_Trai ts> &std::operat or >>(std::basic_i stream<char,_Tr aits> &,unsigned char &)' : could not deduce template argument for 'std::basic_ist ream<char,_Trai ts> &' from 'std::ostream'

Could someone be kind enough to let me know what's wrong with my code????

[gpraghuram]

There was couple of errors in the code

[code=cpp]
//cout >> "Enter 1 (add) or 2 (subtract) or 3 (multiply) or 4 (divide): ";
//This should be
cout << "Enter 1 (add) or 2 (subtract) or 3 (multiply) or 4 (divide): ";

//and you have use enl instead of endl;
cout << "Quotient: " << answer << endl;

[/code]


Raghuram

[rohdej]

Considering this is almost exactly the same as the last post, I will pretty much just copy and paste my last reply, with only a few changes:

You may want to use:

using namespace std;

...because it reduces the number of lines of code and is a more general statement. But beyond this, your code will still fail. The only problem with your code, really, is that you declared the variable "operation" as a char. When you do this, you're getting only the character representation of '1', '2', '3', or '4' as input from the user, and therefore when the program is instructed which operation to perform in your "if" statements, it's essentially using junk data. There are two ways to go about this, the first one requiring fewer changes to your code:

Just change the declaration of "operation" to:

int operation;

...and all will be right with the world again.

Also, in the code you included, you're using a cout with ">>", when it should be "<<" and you spelled "endl" wrong in one spot. Just typos, no biggie.

The following code compiled and ran in Dev-C++ with your desired result:

#include <iostream>

using std::cout;
using std::cin;
using std::endl;

int num1 = 0;
int num2 = 0;
int answer = 0;
int operation;

int main()
{
cout << "Enter first number: ";
cin >> num1;
cout << "Enter 1 (add) or 2 (subtract) or 3 (multiply) or 4 (divide): ";
cin >> operation;
cout << operation;
cout << "Enter second number: ";
cin >> num2;

if (operation == 1)
{
answer = num1 + num2;
cout << "Sum: " << answer << endl;
}
else
if (operation == 2)
{
answer = num1 - num2;
cout << "Difference: " << answer << endl;
}
else
if (operation == 3)
{
answer = num1 * num2;
cout << "Product: " << answer << endl;
}
else
if (operation == 4)
{
answer = num1 / num2;
cout << "Quotient: " << answer << endl;
} //end if

system ("pause");
return 0;
} //end of main function

Just to be thorough, here is the second way to go about this: if you were to keep the declaration as:

char operation;

...then, when you use your "if" statements, they have to look like this:

if (operation == '1');

This way, the "if" statement compares the char input to another char. So the moral of the story is, all you need is to make sure similar data types are being compared in the "if" statement (or any control statement for that matter).

One more thing, while I'm at it... it is widely accepted that you should not use the SYSTEM("PAUSE") command because, depending on your system, instability could result and this is not portable code. I use Windows XP and code with Dev-C++, and I find that the easiest way to keep the console window open is to use:

cin.get();

... before the return statement, which gets input from the current input stream. In your code you should use it twice, as follows:

cin.get();
cin.get();

This is because the first time you call the command, it will "get" the user's last input because that input stream still exists. The second cin.get() call asks for input, but nothing is currently in the stream, so the program holds the window open until it has some kind of input to read. Therefore, you can press enter, the program will read the empty input, and the window closes.