use of unassigned local variable

**pankajvtcse** · Jul 19 '10, 04:46 AM

Originally posted by zeejay

i am having some trouble trying to extract my custID from a SQL database as i keep getting a "use of unassigned local variable " on the custID i have underlined.. can someone help me please!!!

Code:

String[] custID;
            while (thisReader.HasRows)
            {
                while (thisReader.Read())
                {

                    custID[z] = thisReader.GetString(thisReader.GetOrdinal("CustId"));
                }
                z++;
            }
            thisReader.Close();
            thisConnection.Close();

            
            for (int j = 1; j < [U][B][I]custID[/I][/B][/U].Length - 1; j++)
            {
                Label1.Text = custID[j];

            }

thanks a million!!!

The error is due to, you are trying to use the UNASSIGNED variable. custID string array is assigned value inside the WHILE block, this is not sure for the compiler that the code where you are assigning the value to the variable will execute. But the line 15 will surely executed and will generate Error cos the custID might be null.
To avoid this condition you can use default values to be assigned to the variables at the time of declaration.
Modify the code Line 1 to Line 10:

String[] custID = new String[0];
int z = 0;
while (thisReader.Has Rows)
{
while (thisReader.Rea d())
{
Array.Resize<St ring>(ref custID,custID.L ength + 1);
custID[z] = thisReader.GetS tring(thisReade r.GetOrdinal("C ustId"));
}
z++;
}

This will surely work for you.
But instead of using String[] you can also use List<String> this will help you to reduce the code and also List provides extra functionality like sort, search.

List<String> custID = new List<String>();
while (thisReader.Has Rows)
{
while (thisReader.Rea d())
{
custID.Add(this Reader.GetStrin g(thisReader.Ge tOrdinal("CustI d")););
}
}

use of unassigned local variable

use of unassigned local variable

Comment